[Fix] Jest Test e2e #402
[Fix] Jest Test e2e #402
Conversation
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
|
No dependency changes detected. Learn more about Socket for GitHub ↗︎ 👍 No dependency changes detected in pull request |
WalkthroughThe changes introduce a new file Changes
Sequence Diagram(s)sequenceDiagram
participant User
participant Controller
participant DataSource
participant Database
User->>Controller: Request project data
Controller->>DataSource: Get project ID
DataSource->>Database: Query project by ID
Database-->>DataSource: Return project data
DataSource-->>Controller: Return project data
Controller-->>User: Send project data
📜 Recent review detailsConfiguration used: CodeRabbit UI 📒 Files selected for processing (1)
🚧 Files skipped from review as they are similar to previous changes (1)
Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media? 🪧 TipsChatThere are 3 ways to chat with CodeRabbit:
Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (Invoked using PR comments)
Other keywords and placeholders
CodeRabbit Configuration File (
|
![coderabbitai[bot]](https://avatars.githubusercontent.com/in/347564?s=60&v=4){kind=small}
There was a problem hiding this comment.
Actionable comments posted: 7
🧹 Outside diff range and nitpick comments (11)
webapp/.gitignore (1)
Line range hint
1-38: Note on potential formatting changesThe AI summary mentioned some formatting adjustments, such as removing a space before
/connect.lockand ensuring consistent spacing. However, these changes are not visible in the provided code diff. If such changes were made, they are likely minor and do not affect the functionality of the .gitignore file.For future reference, it's generally a good practice to maintain consistent formatting throughout the file, including consistent use of newlines and spaces.
webapp/src/app/projects/components/import-container/import-container.component.ts (1)
34-37: Improved constructor formatting enhances readability.The constructor has been reformatted with each parameter on a separate line. This change improves code readability and maintainability without altering the functionality.
Consider adding a trailing comma after the last parameter for consistency and to make future additions easier:
constructor( private store: Store, - private router: Router, + private router: Router, ) {}webapp/src/app/projects/components/new-term/new-term.component.ts (4)
34-38: Improved constructor formatting enhances readability.The multi-line formatting of the constructor improves code readability and maintainability. This change aligns with common Angular style guidelines and makes it easier to add or modify dependencies in the future.
Consider adding a trailing comma after the last parameter for consistency and to make future additions easier:
constructor( private modalService: NgbModal, private fb: FormBuilder, - private store: Store, + private store: Store, ) {}
Line range hint
52-59: Consider enhancing error handling in theonSubmitmethod.The
onSubmitmethod currently doesn't handle potential errors from theCreateTermaction. Consider adding try-catch block to handle errors gracefully and provide feedback to the user.Here's a suggested improvement:
async onSubmit() { if (!this.form.valid) { return; } try { await this.store.dispatch(new CreateTerm(this.project.id, this.term.value as string, this.context.value as string | undefined)).toPromise(); this.modal.close(); } catch (error) { console.error('Failed to create term:', error); // Handle error (e.g., show error message to user) } }
Line range hint
56-56: Update RxJS usage to avoid deprecation warnings.The
toPromise()method is deprecated in RxJS 7+. Consider usingfirstValueFromorlastValueFromfrom RxJS instead.Here's how you can update the code:
import { firstValueFrom } from 'rxjs'; // In the onSubmit method: await firstValueFrom(this.store.dispatch(new CreateTerm(this.project.id, this.term.value as string, this.context.value as string | undefined)));
Line range hint
71-74: Enhance theresetmethod for more comprehensive cleanup.The current
resetmethod only resets the form and clears messages. Consider also resetting any component state variables if they exist.Here's a suggested improvement:
reset() { this.form.reset(); this.store.dispatch(new ClearMessages()); // Reset any other component state variables here // For example: this.someStateVariable = initialValue; }api/src/controllers/project-stats.controller.ts (2)
40-40: Approved: Improved query condition for project localesThe change to use
{ id: membership.project.id }instead of directly referencingmembership.projectis a good improvement. It ensures that only the project ID is used in the query, which is typically more efficient and aligns with TypeORM best practices for querying relations.For consistency, consider applying this pattern to other similar queries in the codebase if they exist.
To further improve consistency across the codebase, you might want to consider extracting this query condition into a reusable function. For example:
function getProjectIdCondition(project: Project) { return { id: project.id }; } // Usage where: { project: getProjectIdCondition(membership.project), },This would make it easier to maintain consistent query conditions across different parts of the application.
Line range hint
1-124: Consider refactoring thegetStatsmethod for improved readability and maintainabilityWhile the current change is appropriate and improves the query condition, the
getStatsmethod is quite long and complex. Consider breaking it down into smaller, more focused methods to improve readability and maintainability.Here are some suggestions:
- Extract the locale statistics calculation into a separate method.
- Create a helper method for calculating progress percentages.
- Consider using TypeORM's query builder for more complex queries to improve performance and readability.
Here's an example of how you might start refactoring:
private async getLocaleStats(locales: ProjectLocale[], termCount: number): Promise<LocaleStats> { // ... logic for calculating locale stats ... } private calculateProgress(translated: number, total: number): number { return Math.floor((translated / total) * 100) / 100; } @Get() async getStats(@Req() req, @Param('projectId') projectId: string) { const user = this.auth.getRequestUserOrClient(req); const membership = await this.auth.authorizeProjectAction(user, projectId, ProjectAction.ViewTranslation); const locales = await this.getProjectLocales(membership.project.id); const termCount = membership.project.termsCount; const localeStats = await this.getLocaleStats(locales, termCount); const projectStats = this.calculateProjectStats(localeStats, termCount); return { data: { projectStats, localeStats } }; }This refactoring would make the main
getStatsmethod more concise and easier to understand at a glance.api/src/controllers/project-user.controller.ts (1)
Line range hint
101-101: Approved: Improved error message clarityThe error message for the scenario where a user attempts to remove themselves has been clarified, explicitly stating that users cannot edit their own role. This change enhances the consistency of error messaging across the controller.
For even better consistency, consider updating the error message in the
updatemethod (line 63) to match this new wording:- throw new BadRequestException(`can't edit your own role`); + throw new BadRequestException(`can't edit your own role`);This will ensure uniform error messaging throughout the controller.
api/src/connection/datasource.ts (2)
15-15: Ensure proper fallback for database port configurationUsing
parseInt(env.TR_DB_PORT, 10) || 3306works becauseNaNis falsy in JavaScript. However, for clarity and to avoid potential pitfalls, consider explicitly checking ifparseIntreturns a valid number.Apply this diff to improve clarity:
- port: parseInt(env.TR_DB_PORT, 10) || 3306, + port: isNaN(parseInt(env.TR_DB_PORT, 10)) ? 3306 : parseInt(env.TR_DB_PORT, 10),
41-41: Enhance error logging for better debuggingOnly logging
error.messagemight omit valuable stack trace information that can aid in debugging. Consider logging the entire error object to capture complete details about the exception.Apply this diff to improve error logging:
- console.error(error?.message); + console.error('DataSource initialization error:', error);This change provides more context and helps in diagnosing initialization issues.
📜 Review details
Configuration used: CodeRabbit UI
Review profile: CHILL
⛔ Files ignored due to path filters (1)
yarn.lockis excluded by!**/yarn.lock,!**/*.lock
📒 Files selected for processing (40)
- api/src/connection/datasource.ts (1 hunks)
- api/src/controllers/exports.controller.ts (2 hunks)
- api/src/controllers/import.controller.ts (1 hunks)
- api/src/controllers/project-label.controller.ts (5 hunks)
- api/src/controllers/project-stats.controller.ts (1 hunks)
- api/src/controllers/project-user.controller.ts (1 hunks)
- api/src/controllers/term.controller.ts (2 hunks)
- api/src/controllers/translation.controller.ts (6 hunks)
- api/src/controllers/user.controller.ts (1 hunks)
- api/test/jest-e2e.json (1 hunks)
- api/test/user.e2e-spec.ts (5 hunks)
- api/test/util.ts (1 hunks)
- webapp/.gitignore (1 hunks)
- webapp/src/app/auth/components/callback/callback.component.ts (1 hunks)
- webapp/src/app/auth/components/forgot-password/forgot-password.component.ts (1 hunks)
- webapp/src/app/auth/components/login/login.component.ts (1 hunks)
- webapp/src/app/auth/components/reset-password/reset-password.component.ts (1 hunks)
- webapp/src/app/auth/components/signup/signup.component.ts (1 hunks)
- webapp/src/app/auth/components/user-settings/user-settings.component.ts (1 hunks)
- webapp/src/app/auth/stores/auth.state.ts (5 hunks)
- webapp/src/app/projects/components/add-api-client/add-api-client.component.ts (1 hunks)
- webapp/src/app/projects/components/add-team-member/add-team-member.component.ts (1 hunks)
- webapp/src/app/projects/components/assigned-labels/assigned-labels.component.ts (1 hunks)
- webapp/src/app/projects/components/edit-label/edit-label.component.ts (1 hunks)
- webapp/src/app/projects/components/import-container/import-container.component.ts (1 hunks)
- webapp/src/app/projects/components/import-locale/import-locale.component.ts (1 hunks)
- webapp/src/app/projects/components/new-label/new-label.component.ts (1 hunks)
- webapp/src/app/projects/components/new-project/new-project.component.ts (1 hunks)
- webapp/src/app/projects/components/new-term/new-term.component.ts (1 hunks)
- webapp/src/app/projects/components/project-container/project-container.component.ts (1 hunks)
- webapp/src/app/projects/components/project-locales/project-locales.component.ts (1 hunks)
- webapp/src/app/projects/components/project-settings/project-settings.component.ts (1 hunks)
- webapp/src/app/projects/components/translations-list/translations-list.component.ts (1 hunks)
- webapp/src/app/projects/stores/project-client.state.ts (2 hunks)
- webapp/src/app/projects/stores/project-invite.state.ts (2 hunks)
- webapp/src/app/projects/stores/project-label.state.ts (2 hunks)
- webapp/src/app/projects/stores/project-user.state.ts (2 hunks)
- webapp/src/app/projects/stores/projects.state.ts (3 hunks)
- webapp/src/app/projects/stores/terms.state.ts (1 hunks)
- webapp/src/app/projects/stores/translations.state.ts (1 hunks)
✅ Files skipped from review due to trivial changes (23)
- api/src/controllers/user.controller.ts
- webapp/src/app/auth/components/callback/callback.component.ts
- webapp/src/app/auth/components/forgot-password/forgot-password.component.ts
- webapp/src/app/auth/components/login/login.component.ts
- webapp/src/app/auth/components/reset-password/reset-password.component.ts
- webapp/src/app/auth/components/signup/signup.component.ts
- webapp/src/app/auth/components/user-settings/user-settings.component.ts
- webapp/src/app/auth/stores/auth.state.ts
- webapp/src/app/projects/components/add-team-member/add-team-member.component.ts
- webapp/src/app/projects/components/assigned-labels/assigned-labels.component.ts
- webapp/src/app/projects/components/edit-label/edit-label.component.ts
- webapp/src/app/projects/components/import-locale/import-locale.component.ts
- webapp/src/app/projects/components/new-label/new-label.component.ts
- webapp/src/app/projects/components/new-project/new-project.component.ts
- webapp/src/app/projects/components/project-container/project-container.component.ts
- webapp/src/app/projects/components/project-locales/project-locales.component.ts
- webapp/src/app/projects/components/project-settings/project-settings.component.ts
- webapp/src/app/projects/components/translations-list/translations-list.component.ts
- webapp/src/app/projects/stores/project-client.state.ts
- webapp/src/app/projects/stores/project-label.state.ts
- webapp/src/app/projects/stores/project-user.state.ts
- webapp/src/app/projects/stores/projects.state.ts
- webapp/src/app/projects/stores/terms.state.ts
🧰 Additional context used
🔇 Additional comments (45)
api/test/jest-e2e.json (2)
2-6: LGTM: Improved readability ofmoduleFileExtensionsThe reformatting of the
moduleFileExtensionsarray improves readability without changing functionality. This change aligns with common JSON formatting practices.
9-9: Verify the need for increasedtestTimeoutThe test timeout has been doubled from 60 seconds to 120 seconds. While this change can prevent timeouts for longer-running tests, it might also mask performance issues or infinite loops.
Please confirm:
- Are there specific tests that require this extended timeout?
- Have you investigated potential performance improvements in the tests themselves?
- Is this change temporary or a long-term solution?
Consider adding a comment in the configuration file explaining the reason for this extended timeout if it's addressing a specific issue.
webapp/.gitignore (1)
29-29: LGTM: Good addition to .gitignoreAdding
/.cacheto the .gitignore file is a beneficial change. This prevents temporary cache files from being tracked by version control, which is a good practice as these files are typically system-specific and don't need to be shared across the team.webapp/src/app/projects/components/add-api-client/add-api-client.component.ts (1)
41-45: Improved constructor readabilityThe constructor has been reformatted to a multi-line style, which enhances code readability. This change aligns with common Angular style guidelines and makes the code easier to maintain. The functionality remains unchanged, and the modification is consistent with the overall code structure.
api/src/controllers/project-user.controller.ts (1)
16-19: LGTM: Improved constructor formattingThe constructor parameters have been reformatted for better readability, with each parameter on a new line. This change enhances code clarity without altering the functionality.
webapp/src/app/projects/stores/project-invite.state.ts (5)
23-27: LGTM: Improved constructor formattingThe constructor parameters for
AddProjectInvitehave been moved to separate lines, which improves readability without affecting functionality. This change aligns with modern TypeScript style guidelines.
32-36: LGTM: Consistent constructor formattingThe constructor parameters for
UpdateProjectInvitehave been formatted consistently with the previous change, improving readability while maintaining functionality.
41-44: LGTM: Consistent formatting appliedThe constructor for
RemoveProjectInvitehas been formatted consistently with the previous changes, enhancing code readability.
65-68: LGTM: Consistent formatting throughout the fileThe constructor for
ProjectInviteStatehas been formatted consistently with the previous changes. This change completes the formatting updates, ensuring consistency throughout the entire file. The improved readability will benefit future maintenance and development efforts.
Line range hint
23-68: Overall: Excellent formatting improvementsThe changes in this file consist entirely of formatting improvements to the constructors of various classes. These changes enhance code readability and maintain consistency throughout the file, adhering to modern TypeScript style guidelines. No functional changes were made, and no potential issues were introduced. These improvements will facilitate easier maintenance and development in the future.
api/src/controllers/term.controller.ts (3)
78-80: Improved query specificity for project referenceThis change enhances the clarity of the project reference in the query. By explicitly specifying
{ id: membership.project.id }instead of justmembership.project, the code becomes more precise about which project property is being used for filtering. This approach aligns with TypeORM best practices and can potentially improve query performance.
148-148: Consistent query specificity improvementThis change aligns with the earlier modification in the
createmethod, ensuring a consistent approach to project references across the controller. By using{ id: membership.project.id }instead ofmembership.project, the code maintains a clear and explicit reference to the project's ID. This consistency enhances code readability and reduces the potential for misinterpretation.
Line range hint
1-152: Consider applying similar changes throughout the codebaseThe improvements made to the project references in queries are beneficial for code clarity and potentially for query performance. To maintain consistency and further enhance the codebase, consider reviewing and applying similar changes to other controllers or services where project references are used in queries. This would ensure a uniform approach across the entire application.
To identify other potential locations for similar improvements, you can run the following script:
This script will help identify other occurrences where project references in queries might benefit from the same explicit ID referencing approach.
api/src/controllers/exports.controller.ts (2)
57-59: Improved query structure for project locale lookup.The change from
project: membership.projecttoproject: { id: membership.project.id }is a good refinement. It makes the query more explicit by using the project's ID, which is typically the primary key. This approach is generally more efficient and less prone to potential issues that might arise from using the entire project object in the query.
103-105: Consistent query structure improvement for fallback locale.This change mirrors the earlier modification, applying the same improved query structure to the fallback locale lookup. It maintains consistency in how project references are handled throughout the method, which is a good practice. This consistency helps in code readability and maintainability.
api/src/controllers/import.controller.ts (1)
97-99: Approve change with verification suggestion.The modification to assign only the project ID instead of the entire project object when creating a new
ProjectLocaleis a good practice. It reduces data redundancy and potential circular reference issues.However, to ensure this change doesn't introduce any regressions:
- Verify that no other part of the codebase relies on accessing full project details directly through the
ProjectLocaleentity.- Update any affected queries or code that might have been expecting the full project object.
- Consider adding a comment explaining the reason for this change to improve code maintainability.
To verify the impact of this change, you can run the following script:
This script will help identify any instances where code might be trying to access project properties other than
idthroughProjectLocale, which could be affected by this change.webapp/src/app/projects/stores/translations.state.ts (5)
31-34: LGTM: Improved constructor formattingThe constructor formatting change enhances readability by placing each parameter on a new line. This aligns with common coding style guidelines and improves maintainability.
39-42: LGTM: Consistent constructor formattingThe constructor formatting change in DeleteProjectLocale class is consistent with the previous change, improving readability and maintainability.
47-50: LGTM: Consistent constructor formattingThe constructor formatting change in GetTranslations class maintains consistency with the previous changes, enhancing code readability.
55-60: LGTM: Improved readability for complex constructorThe constructor formatting change in UpdateTranslation class is particularly beneficial due to the higher number of parameters. This change significantly enhances readability and maintains consistency with the other changes in the file.
31-60: Summary: Consistent formatting improvements across multiple constructorsThe changes in this file consist of consistent formatting improvements to the constructors of four classes: AddProjectLocale, DeleteProjectLocale, GetTranslations, and UpdateTranslation. These changes enhance code readability and maintainability without altering any functionality. The systematic approach to improving code style across multiple classes is commendable and aligns with best practices for code maintenance.
api/src/controllers/translation.controller.ts (5)
47-47: Improved query performance and consistencyThe change to use
project: { id: membership.project.id }instead ofproject: membership.projectis a good improvement. It explicitly references the project ID, which can lead to better query performance and avoids potential issues with circular references. This change aligns well with the PR objective of updating project queries to reference IDs.
98-101: Consistent use of identifiers in queriesThe updates to use
locale: { code: locale.code }andproject: { id: membership.project.id }in the query are good improvements. They maintain consistency with the earlier changes and continue the pattern of using specific identifiers instead of entire objects. This approach can lead to more efficient queries and clearer code.
131-131: Consistent use of project ID in queriesThe update to use
project: { id: membership.project.id }in the query is a good continuation of the pattern established earlier in the file. It maintains consistency in how project references are handled across different methods of the controller.
140-142: Consistent use of IDs in translation queriesThe update to use
projectLocale: { id: projectLocale.id }in the query for finding a translation is a good continuation of the pattern established earlier in the file. It maintains consistency in how entity references are handled across different methods of the controller, using specific IDs instead of entire objects.
240-240: Consistent use of project ID in delete methodThe update to use
project: { id: membership.project.id }in the delete method's query is consistent with the changes made throughout the file. This change completes the pattern of using specific IDs instead of entire objects in queries across all methods in the controller.Overall Impact:
These changes collectively improve the consistency and potentially the performance of database queries throughout theTranslationController. By consistently using IDs and specific fields (likelocale.code) instead of entire objects, the code becomes more explicit about what data it's querying, which can lead to more efficient database operations and easier maintenance. This refactoring aligns well with the PR objective of updating project queries to reference IDs instead of membership objects.api/src/controllers/project-label.controller.ts (6)
110-110: Improved query performance and consistencyThe change to use
project: { id: membership.project.id }instead ofproject: membership.projectis a good improvement. It explicitly references the project ID in the database query, which can lead to better performance and avoid potential issues with object references. This change is consistent with the PR objective of updating queries to reference project IDs.
125-126: Consistent use of project ID in queriesThe changes in the
labelTermmethod are consistent with the improvements made elsewhere in the controller. Both the label and term queries now explicitly useproject: { id: membership.project.id }, which ensures better query performance and maintains consistency across the controller methods. This is a good practice and aligns well with the PR objectives.
152-153: Consistent query improvements in unlabelTerm methodThe changes in the
unlabelTermmethod mirror those made in thelabelTermmethod, maintaining consistency across the controller. Both label and term queries now explicitly useproject: { id: membership.project.id }, which is in line with the PR objectives and best practices for database queries.
177-183: Comprehensive query improvements in labelTranslation methodThe changes in the
labelTranslationmethod are thorough and consistent with the improvements made throughout the controller. All queries now explicitly use IDs:
- The label query uses
project: { id: membership.project.id }.- The projectLocale query uses
project: { id: membership.project.id }.- The translation query uses
projectLocale: { id: projectLocale.id }.These changes enhance query performance and maintain consistency. The use of
projectLocale.idin the translation query is particularly noteworthy as it ensures we're using the correct project locale. These improvements align well with the PR objectives and database best practices.Also applies to: 191-191
217-221: Consistent query improvements in unlabelTranslation methodThe changes in the
unlabelTranslationmethod mirror those made in thelabelTranslationmethod, maintaining consistency across the controller. All queries now explicitly use IDs:
- The label query uses
project: { id: membership.project.id }.- The projectLocale query uses
project: { id: membership.project.id }.- The translation query uses
projectLocale: { id: projectLocale.id }.These changes enhance query performance, maintain consistency, and ensure the use of the correct project locale. The improvements align well with the PR objectives and database best practices.
Also applies to: 229-229
Line range hint
1-236: Overall improvement in query structure and consistencyThe changes implemented across the
ProjectLabelControllerconsistently improve the way project and label relationships are queried. By explicitly using IDs in all database queries (project: { id: membership.project.id }andprojectLocale: { id: projectLocale.id }), these modifications enhance query performance and maintain consistency throughout the controller.These improvements align well with the PR objectives and adhere to database best practices. They potentially enhance the overall performance of the application and improve code quality by making the queries more explicit and easier to understand.
Great job on maintaining consistency across all methods and implementing these beneficial changes!
api/test/util.ts (7)
103-106: Well-Documented Function DescriptionThe JSDoc comments provide a clear and detailed explanation of the function's purpose and return value.
109-109: Compilation of Testing Module is CorrectThe testing module for
AppModuleis being compiled correctly usingTest.createTestingModule. This ensures that all dependencies are properly initialized for testing.
112-113: Application Initialization is Properly HandledThe Nest application instance is correctly created using the
ExpressAdapter, which is suitable for testing environments.
114-114: Middleware, Pipes, and Filters are AppliedThe call to
addPipesAndFilters(app);applies necessary middleware, pipes, and filters to the application, ensuring consistency with the main application configuration.
118-119: Application Initialization CompletedThe application is initialized with
await app.init();, preparing it for handling requests during tests.
120-120: Database Connection Retrieved SuccessfullyThe database connection is obtained using
app.get(Connection);, allowing direct interaction with the database for setup and teardown operations.
134-134: Application is Returned SuccessfullyThe initialized application is returned as expected, allowing tests to proceed using the configured instance.
api/test/user.e2e-spec.ts (6)
1-1: Updated import to use 'DataSource' from TypeORMSwitching to import
DataSourcealigns with the latest TypeORM practices and ensures compatibility with newer versions.
4-4: Importing 'getDataSourceConnection' for consistent DataSource initializationImporting
getDataSourceConnectionensures that the tests use a consistent method for establishing the database connection.
13-13: Declaring 'connection' as a DataSource instanceProperly declaring
connectionas aDataSourcereinforces type safety and clarity in the code.
22-22: Initializing 'connection' within 'beforeEach'Assigning
connectionusingawait getDataSourceConnection()correctly establishes the database connection before each test.
229-229: Consistent use of 'connection.getRepository' enhances reliabilityUpdating repository access to use
connection.getRepositoryties all database operations to the specificDataSourceinstance, improving test reliability and ensuring that all operations use the same connection context.Also applies to: 233-233, 237-237
247-247: Proper cleanup of DataSource with 'connection.destroy()'Calling
await connection.destroy()ensures that the database connection is properly closed after each test, preventing potential resource leaks.
There was a problem hiding this comment.
Actionable comments posted: 1
📜 Review details
Configuration used: CodeRabbit UI
Review profile: CHILL
⛔ Files ignored due to path filters (1)
yarn.lockis excluded by!**/yarn.lock,!**/*.lock
📒 Files selected for processing (1)
- api/src/connection/datasource.ts (1 hunks)
🧰 Additional context used
🪛 Biome
api/src/connection/datasource.ts
[error] 17-17: isNaN is unsafe. It attempts a type coercion. Use Number.isNaN instead.
See the MDN documentation for more details.
Unsafe fix: Use Number.isNaN instead.(lint/suspicious/noGlobalIsNan)
Before submitting the PR, please make sure you do the following
Contributor license agreement
For us it's important to have the agreement of our contributors to use their work, whether it be code or documentation. Therefore, we are asking all contributors to sign a contributor license agreement (CLA) as commonly accepted in most open source projects. Just open the pull request and our CLA bot will prompt you briefly.
Please check our contribution guidelines for some help in the process.
Summary by CodeRabbit
New Features
Bug Fixes
Documentation
Style
.gitignoreto include new entries and improve formatting.angular.jsonand configuration files for consistency.Tests