Skip to content
This repository has been archived by the owner on Apr 4, 2024. It is now read-only.

Check EnableCreate/EnableCall in ante handler #1060

Merged
merged 4 commits into from
May 3, 2022

Conversation

yihuang
Copy link
Contributor

@yihuang yihuang commented Apr 21, 2022

Description

WIP: #1045

Reject tx early in ante handler, avoid deduct user fee for vain.


For contributor use:

  • Targeted PR against correct branch (see CONTRIBUTING.md)
  • Linked to Github issue with discussion and accepted design OR link to spec that describes this work.
  • Code follows the module structure standards.
  • Wrote unit and integration tests
  • Updated relevant documentation (docs/) or specification (x/<module>/spec/)
  • Added relevant godoc comments.
  • Added a relevant changelog entry to the Unreleased section in CHANGELOG.md
  • Re-reviewed Files changed in the Github PR explorer

For admin use:

  • Added appropriate labels to PR (ex. WIP, R4R, docs, etc)
  • Reviewers assigned
  • Squashed all commits, uses message "Merge pull request #XYZ: [title]" (coding standards)

@fedekunze fedekunze marked this pull request as draft April 21, 2022 13:37
@codecov
Copy link

codecov bot commented Apr 21, 2022

Codecov Report

Merging #1060 (7081d60) into main (a4b8816) will increase coverage by 0.03%.
The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##             main    #1060      +/-   ##
==========================================
+ Coverage   59.46%   59.49%   +0.03%     
==========================================
  Files          84       84              
  Lines        6934     6940       +6     
==========================================
+ Hits         4123     4129       +6     
  Misses       2598     2598              
  Partials      213      213              
Impacted Files Coverage Δ
app/ante/eth.go 82.68% <100.00%> (+0.31%) ⬆️

CHANGELOG.md Outdated Show resolved Hide resolved
WIP: evmos#1045

Reject tx early in ante handler, avoid deduct user fee for vain.
@yihuang yihuang force-pushed the reject-tx-in-ante-handler branch from 3916103 to 4058594 Compare May 3, 2022 01:59
@yihuang yihuang marked this pull request as ready for review May 3, 2022 02:19
CHANGELOG.md Outdated Show resolved Hide resolved
Copy link
Contributor

@fedekunze fedekunze left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. See comment about breaking change

@fedekunze fedekunze merged commit 93d15db into evmos:main May 3, 2022
@yihuang yihuang deleted the reject-tx-in-ante-handler branch May 4, 2022 01:15
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants