Skip to content
This repository has been archived by the owner on Apr 4, 2024. It is now read-only.

imp, ci: address pending issues from EVM simulation #1063

Merged
merged 20 commits into from
May 2, 2022

Conversation

adu-web3
Copy link
Contributor

@adu-web3 adu-web3 commented Apr 22, 2022

Description

fix the remained issues in last pr #996 :

  • add paramChanges for other parameter.
  • add more tests for new functions.
  • add comment for random value generation in simulation.
  • update github actions to run simulation in CI.
______

For contributor use:

  • Targeted PR against correct branch (see CONTRIBUTING.md)
  • Linked to Github issue with discussion and accepted design OR link to spec that describes this work.
  • Code follows the module structure standards.
  • Wrote unit and integration tests
  • Updated relevant documentation (docs/) or specification (x/<module>/spec/)
  • Added relevant godoc comments.
  • Added a relevant changelog entry to the Unreleased section in CHANGELOG.md
  • Re-reviewed Files changed in the Github PR explorer

For admin use:

  • Added appropriate labels to PR (ex. WIP, R4R, docs, etc)
  • Reviewers assigned
  • Squashed all commits, uses message "Merge pull request #XYZ: [title]" (coding standards)

@codecov
Copy link

codecov bot commented Apr 22, 2022

Codecov Report

Merging #1063 (28e051b) into main (c25669c) will decrease coverage by 1.40%.
The diff coverage is 78.57%.

Impacted file tree graph

@@            Coverage Diff             @@
##             main    #1063      +/-   ##
==========================================
- Coverage   60.87%   59.46%   -1.41%     
==========================================
  Files          80       84       +4     
  Lines        6683     6935     +252     
==========================================
+ Hits         4068     4124      +56     
- Misses       2404     2598     +194     
- Partials      211      213       +2     
Impacted Files Coverage Δ
x/evm/simulation/operations.go 0.00% <0.00%> (ø)
x/evm/simulation/params.go 87.50% <83.33%> (ø)
app/utils.go 34.83% <100.00%> (ø)
x/evm/simulation/decoder.go 86.66% <100.00%> (ø)
x/evm/simulation/genesis.go 93.54% <100.00%> (ø)

@adu-web3 adu-web3 marked this pull request as ready for review April 28, 2022 09:43
x/evm/simulation/genesis.go Show resolved Hide resolved
x/evm/simulation/genesis.go Show resolved Hide resolved
x/evm/simulation/genesis.go Outdated Show resolved Hide resolved
@fedekunze fedekunze changed the title Evm simulation: fix remained issues imp, ci: address pending issues from EVM simulation Apr 30, 2022
@fedekunze fedekunze enabled auto-merge (squash) May 2, 2022 11:27
@fedekunze fedekunze merged commit 4ea9b6d into evmos:main May 2, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants