Skip to content
This repository has been archived by the owner on Apr 4, 2024. It is now read-only.

Integration tests setup #1196

Merged
merged 19 commits into from
Jul 27, 2022
Merged

Conversation

crypto-facs
Copy link
Contributor

@crypto-facs crypto-facs commented Jul 21, 2022

Description

Started migrating some parts from the setup @yihuang had done in cronos to better test RPC endpoints with multiple configurations.

Tests are written in python to take advantage of pystarport for node configuration and also because of the extensive w3 library support for easy testing. Nix was used to manage reproducible builds and easy composability of dependencies.

This configurations currently allows to setup a basic ethermint and geth node and expect tests to pass on both networks. At the moment I just added a super simple test_basic to prove the concept as the configuration itself is very complex.

Openning as a first draft to get some comments on it and as a foundation on which to build a robust test suite to maintain better reliabily on the RPC nodes. I will add extensive tests once this PR is merged and also other several configurations on which to tests like pruned_nodes, which should be straightforward with this suite as it has been done in Cronos.

Big shoutout to @yihuang for setting this up


For contributor use:

  • Targeted PR against correct branch (see CONTRIBUTING.md)
  • Linked to Github issue with discussion and accepted design OR link to spec that describes this work.
  • Code follows the module structure standards.
  • Wrote unit and integration tests
  • Updated relevant documentation (docs/) or specification (x/<module>/spec/)
  • Added relevant godoc comments.
  • Added a relevant changelog entry to the Unreleased section in CHANGELOG.md
  • Re-reviewed Files changed in the Github PR explorer

For admin use:

  • Added appropriate labels to PR (ex. WIP, R4R, docs, etc)
  • Reviewers assigned
  • Squashed all commits, uses message "Merge pull request #XYZ: [title]" (coding standards)

.github/workflows/test.yml Outdated Show resolved Hide resolved
result Outdated Show resolved Hide resolved
Copy link
Contributor

@yihuang yihuang left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, left small cleanup suggestions.

Copy link
Contributor

@fedekunze fedekunze left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@crypto-facs can you move the tests to the existing tests/ directory?

.github/workflows/test.yml Show resolved Hide resolved
scripts/ethermint-devnet.yaml Show resolved Hide resolved
result Outdated Show resolved Hide resolved
Copy link
Contributor

@yihuang yihuang left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Makefile Show resolved Hide resolved
Makefile Show resolved Hide resolved
nix/go-ethereum.nix Outdated Show resolved Hide resolved
@fedekunze fedekunze enabled auto-merge (squash) July 25, 2022 16:35
@fedekunze fedekunze merged commit fd0e62a into evmos:main Jul 27, 2022
facs95 pushed a commit that referenced this pull request Aug 12, 2022
* first pass

* latest

* working tests

* github actions

* remove unnecessary change

* remove unnecessary steps

* remove unnecessary import

* remove unnecessary change

* Update .github/workflows/test.yml

Co-authored-by: yihuang <[email protected]>

* update .gitignore

* update github actions

* change evm denomination

* change evm denomination

* send tests to tests folder

* Delete result

* update go version

Co-authored-by: yihuang <[email protected]>
Co-authored-by: Federico Kunze Küllmer <[email protected]>
hoanguyenkh pushed a commit to AstraProtocol/ethermint that referenced this pull request Aug 17, 2022
* first pass

* latest

* working tests

* github actions

* remove unnecessary change

* remove unnecessary steps

* remove unnecessary import

* remove unnecessary change

* Update .github/workflows/test.yml

Co-authored-by: yihuang <[email protected]>

* update .gitignore

* update github actions

* change evm denomination

* change evm denomination

* send tests to tests folder

* Delete result

* update go version

Co-authored-by: yihuang <[email protected]>
Co-authored-by: Federico Kunze Küllmer <[email protected]>
devon-chain pushed a commit to PundiAI/ethermint that referenced this pull request Nov 17, 2022
* first pass

* latest

* working tests

* github actions

* remove unnecessary change

* remove unnecessary steps

* remove unnecessary import

* remove unnecessary change

* Update .github/workflows/test.yml

Co-authored-by: yihuang <[email protected]>

* update .gitignore

* update github actions

* change evm denomination

* change evm denomination

* send tests to tests folder

* Delete result

* update go version

Co-authored-by: yihuang <[email protected]>
Co-authored-by: Federico Kunze Küllmer <[email protected]>
(cherry picked from commit 60598ab)
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants