Skip to content
This repository has been archived by the owner on Apr 4, 2024. It is now read-only.

fix(rpc): patch gas used api for block less than upgrade height #1557

Merged
merged 14 commits into from
Jan 16, 2023

Conversation

mmsqe
Copy link
Contributor

@mmsqe mmsqe commented Dec 16, 2022

Updates: crypto-org-chain/cronos#792

Description


For contributor use:

  • Targeted PR against correct branch (see CONTRIBUTING.md)
  • Linked to Github issue with discussion and accepted design OR link to spec that describes this work.
  • Code follows the module structure standards.
  • Wrote unit and integration tests
  • Updated relevant documentation (docs/) or specification (x/<module>/spec/)
  • Added relevant godoc comments.
  • Added a relevant changelog entry to the Unreleased section in CHANGELOG.md
  • Re-reviewed Files changed in the Github PR explorer

For admin use:

  • Added appropriate labels to PR (ex. WIP, R4R, docs, etc)
  • Reviewers assigned
  • Squashed all commits, uses message "Merge pull request #XYZ: [title]" (coding standards)

@codecov
Copy link

codecov bot commented Dec 16, 2022

Codecov Report

Merging #1557 (57d433d) into main (5f7ee9b) will increase coverage by 0.02%.
The diff coverage is 61.36%.

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##             main    #1557      +/-   ##
==========================================
+ Coverage   68.33%   68.35%   +0.02%     
==========================================
  Files         110      110              
  Lines       10171    10181      +10     
==========================================
+ Hits         6950     6959       +9     
- Misses       2818     2819       +1     
  Partials      403      403              
Impacted Files Coverage Δ
server/config/config.go 22.85% <51.42%> (+0.31%) ⬆️
rpc/backend/tx_info.go 64.47% <100.00%> (+0.96%) ⬆️

@mmsqe mmsqe marked this pull request as ready for review December 19, 2022 01:40
@mmsqe mmsqe requested a review from a team as a code owner December 19, 2022 01:40
@mmsqe mmsqe requested review from Vvaradinov and ramacarlucho and removed request for a team December 19, 2022 01:40
@mmsqe mmsqe changed the title fix: patch gas used api for block less than upgrade height fix(rpc): patch gas used api for block less than upgrade height Jan 5, 2023
@facs95 facs95 merged commit c5fdad7 into evmos:main Jan 16, 2023
mmsqe added a commit to mmsqe/ethermint that referenced this pull request Mar 14, 2023
…s#1557)

* patch gas used api for block less than upgrade height

* configurable fix-revert-gas-refund-height

* add test

* fix flag

* update dep

* set default FixRevertGasRefundHeight

* minor comments fix

* fix lint

Co-authored-by: Federico Kunze Küllmer <[email protected]>
Co-authored-by: Freddy Caceres <[email protected]>
mmsqe added a commit to crypto-org-chain/ethermint that referenced this pull request Mar 14, 2023
…s#1557) (#222)

* patch gas used api for block less than upgrade height

* configurable fix-revert-gas-refund-height

* add test

* fix flag

* update dep

* set default FixRevertGasRefundHeight

* minor comments fix

* fix lint

Co-authored-by: Federico Kunze Küllmer <[email protected]>
Co-authored-by: Freddy Caceres <[email protected]>
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants