Skip to content
This repository has been archived by the owner on Apr 4, 2024. It is now read-only.

rpc test fix #608

Merged
merged 18 commits into from
Oct 7, 2021
Merged

rpc test fix #608

merged 18 commits into from
Oct 7, 2021

Conversation

JayT106
Copy link
Contributor

@JayT106 JayT106 commented Sep 29, 2021 •
edited
Loading

fixes make test-rpc

Closes: #XXX

Description

For contributor use:

  • Targeted PR against correct branch (see CONTRIBUTING.md)
  • Linked to Github issue with discussion and accepted design OR link to spec that describes this work.
  • Code follows the module structure standards.
  • Wrote unit and integration tests
  • Updated relevant documentation (docs/) or specification (x/<module>/spec/)
  • Added relevant godoc comments.
  • Added a relevant changelog entry to the Unreleased section in CHANGELOG.md
  • Re-reviewed Files changed in the Github PR explorer

For admin use:

  • Added appropriate labels to PR (ex. WIP, R4R, docs, etc)
  • Reviewers assigned
  • Squashed all commits, uses message "Merge pull request #XYZ: [title]" (coding standards)

@JayT106 JayT106 changed the title Rpc test fix (DNM) Rpc test fix - WIP Sep 30, 2021
@fedekunze fedekunze marked this pull request as draft September 30, 2021 09:01
@JayT106 JayT106 mentioned this pull request Oct 5, 2021
Closed
@JayT106 JayT106 force-pushed the rpctest-fix branch 3 times, most recently from 69eb119 to acad9ca Compare October 7, 2021 02:27
@JayT106 JayT106 changed the title Rpc test fix - WIP Rpc test fix Oct 7, 2021
@JayT106 JayT106 changed the title Rpc test fix rpc test fix Oct 7, 2021
@JayT106
Copy link
Contributor Author

JayT106 commented Oct 7, 2021

@fedekunze is it possible to update the linter version in CI? my current version 1.38.0 has no error reports.
And the PR is ready to merge.

@JayT106 JayT106 marked this pull request as ready for review October 7, 2021 13:15
fedekunze
fedekunze reviewed Oct 7, 2021
View reviewed changes
Copy link
Contributor

@fedekunze fedekunze left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, can you add it to GitHub actions too?

@JayT106
Copy link
Contributor Author

JayT106 commented Oct 7, 2021 •
edited
Loading

LGTM, can you add it to GitHub actions too?

Done! Thanks for the review.

@fedekunze fedekunze merged commit f69c887 into evmos:main Oct 7, 2021
@JayT106 JayT106 mentioned this pull request Oct 7, 2021
Closed
fedekunze pushed a commit that referenced this pull request Oct 8, 2021
@JayT106 @fedekunze
rpc: test fix (#608)
094a688 
* fix rpc tests with net namespace

* skip personal test

* skip rpc pending test

* fix endpoint

* fix rpc pending test

* fix missing gas param in some rpc tests

* fix eth_getproof when the block number is equal to pending or latest

* fix rpc tests filter subscribe failed

* lint

* remove unused linter

* fix PendingTransactionFilter and TestEth_GetFilterChanges_BlockFilter

* fix eth_estimateGas

* fix TestEth_EstimateGas_ContractDeployment

* skip TestEth_ExportAccount_WithStorage

* remove sleep in rpc test

* Update changelog

* add test-rpc in github action

* bump golangci-lint version to v1.42.1
fedekunze added a commit that referenced this pull request Oct 8, 2021
@fedekunze @danburck
@thomas-nguy @JayT106 @yijiasu-crypto @yihuang
release: cherry picks v0.7.1 (#653)
222420f 
* ci: add bencher config (#652)

Add bencher config with global +-10% threshold for improvements and regressions

Co-authored-by: Federico Kunze Küllmer <[email protected]>

* fix conflicts

* evm: fix panic when transaction is reverted (#650)

* fix panic when transaction is reverted

* update changelog

* Update x/evm/keeper/context_stack.go

Co-authored-by: Federico Kunze Küllmer <[email protected]>

* rpc: test fix (#608)

* fix rpc tests with net namespace

* skip personal test

* skip rpc pending test

* fix endpoint

* fix rpc pending test

* fix missing gas param in some rpc tests

* fix eth_getproof when the block number is equal to pending or latest

* fix rpc tests filter subscribe failed

* lint

* remove unused linter

* fix PendingTransactionFilter and TestEth_GetFilterChanges_BlockFilter

* fix eth_estimateGas

* fix TestEth_EstimateGas_ContractDeployment

* skip TestEth_ExportAccount_WithStorage

* remove sleep in rpc test

* Update changelog

* add test-rpc in github action

* bump golangci-lint version to v1.42.1

* release: v0.7.1 cherry-picks

* changelog

* ci: fix solidity tests (#278)

* Fix CI

* Remove verbose-log to reduce size

* update timeout

* rm deploy contract action

* Update test-helper.js

* Update workflow

* Update workflow

* fix gas estimate amount

* Update test.yml

* fix error assert issue

* ignore bad test case

* remove estimate gas test

* Change fromBlock to 1 (TEMP, Reverse Required)

* bump timeout

Co-authored-by: Federico Kunze Küllmer <[email protected]>
Co-authored-by: yihuang <[email protected]>
Co-authored-by: Federico Kunze <[email protected]>

Co-authored-by: Daniel Burckhardt <[email protected]>
Co-authored-by: Thomas Nguy <[email protected]>
Co-authored-by: JayT106 <[email protected]>
Co-authored-by: Yijia Su <[email protected]>
Co-authored-by: yihuang <[email protected]>
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@fedekunze fedekunze fedekunze approved these changes

@jolube jolube Awaiting requested review from jolube

@khoslaventures khoslaventures Awaiting requested review from khoslaventures

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@JayT106 @fedekunze