Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Draft] Adding docs #161

Merged
merged 50 commits into from
Apr 7, 2024
Merged

[Draft] Adding docs #161

merged 50 commits into from
Apr 7, 2024

Conversation

dwreeves
Copy link
Collaborator

No description provided.

@dwreeves
Copy link
Collaborator Author

This PR combines both some necessary code changes as well as very preliminary docs.

I need to get 1.8 in by the time Astronomer Cosmos releases 1.4, as I am writing a blog post that will do some very minor cross promotion of Rich-Click (basically, I encourage users to alias their dbt command to .venv_dbt/bin/rich-click dbt). And without 1.8's performance improvements, I don't feel comfortable suggesting to users to do that, since the dbt command already has massive overhead and I want to add to that as little as possible.

I'm a busy guy though, so this may mean foregoing some of the docs stuff. I hope not but we'll see.

@dwreeves
Copy link
Collaborator Author

dwreeves commented Feb 24, 2024

Bad PR hygiene (should have been a separate PR), but the behaviors for patching in the rich-click CLI are cemented, properly unit-tested, etc. 😄

No idea what's going on with the click 7.x tests though.

@dwreeves
Copy link
Collaborator Author

I need to get 1.8 in by the time Astronomer Cosmos releases 1.4

I don't think this is happening (I'm just way too busy right now), but it's fine.

@dwreeves
Copy link
Collaborator Author

This goes hard.

Just need to fix up a few things, and add the auto-code gen part.

image

@dwreeves
Copy link
Collaborator Author

dwreeves commented Apr 6, 2024

Sooooooooooooooooooo close. So so so so very close.

@dwreeves dwreeves merged commit e7f5590 into ewels:main Apr 7, 2024
32 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant