Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Finalize the API changes for 2.0 #374

Merged
merged 3 commits into from
Apr 16, 2024
Merged

Finalize the API changes for 2.0 #374

merged 3 commits into from
Apr 16, 2024

Conversation

danieldk
Copy link
Contributor

Description

Update the API according to the 1.x to 2.x transition notes:

  • qkv_split arguments for attention head configs are now mandatory.
  • Rename FromHFHub mixins to FromHF.
  • Remove FromHF.convert_hf_state_dict

Checklist

  • I confirm that I have the right to submit this contribution under the project's MIT license.

@danieldk danieldk added the type/maintenance Type: Maintenance label Apr 16, 2024
@danieldk danieldk merged commit 8debb21 into explosion:main Apr 16, 2024
7 of 8 checks passed
@danieldk danieldk deleted the maintenance/remove-api-compat-2.0 branch April 16, 2024 07:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
type/maintenance Type: Maintenance
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@danieldk