Add floret Wikipedia+OSCAR vectors project #99
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This will require thinc v8.0.15 with explosion/thinc#610. |
* add `n_process_wikiextractor` * skip tests in not-linux because `wikiextractor` requires `fork`
svlandeg
reviewed
Mar 29, 2022
| @@ -31,12 +31,15 @@ jobs: | |||
| architecture: 'x64' | |||
|
|
|||
| - script: | | |||
| pip install "spacy>=3.1.0,<3.2.0" | |||
| pip install "spacy>=3.2.0,<3.3.0" | |||
There was a problem hiding this comment.
Do you think there will be something breaking in 3.3? Considering that release is near, it might be nice to make sure it's supported too?
There was a problem hiding this comment.
Sure, but maybe in a separate PR after v3.3 is released?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add a user-friendly cross-platform floret vectors project for training on Wikipedia (using
wikiextractor) + OSCAR (usingdatasets).The project defaults use Macedonian to provide a small but realistic demo.
The tests override the defaults to use the much-smaller Yoruba data sources.