-
-
Notifications
You must be signed in to change notification settings - Fork 4.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
ner.add_label to existing model causes segmentation fault: 11 #2769
Comments
Thanks for the report. Are you able to share the examples you used and/or the labels you're adding? And do you have a reproducible example? Segfaults like this are always tricky to debug, so the more specific examples we have, the better. |
The minimal reproducible example is the train_new_entity_type.py example script with the 'en' model loaded, with no other changes. That script adds the 'ANIMAL' entity tag. Note that this particular error is only with the nightly build. The intermittent segmentation faults I referenced happened with other data on the release build, but that issue has been mentioned in the past and is still open - #1969 |
@iperera do you get the segfault even when just running that example file? It ran fine for me, on a mac using Python 3.7. |
Only when specifying an existing model to add to. If I start with a blank model, it runs fine for me. |
I also get a segmentation fault using the standard training code when I try add a label to the NER with ner.add_label("FEATURE") This is on the latest nightly build
|
@nyejon Thanks for the example! I just tested it on the very latest state of Here's the minimal reproducable version: import spacy
nlp = spacy.load("en_core_web_sm")
ner = nlp.get_pipe("ner")
ner.add_label("FEATURE") |
Fixed 🎉 160b55c |
This thread has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs. |
I was getting intermittent segmentation faults when training a new entity type, and so I thought I'd update spaCy to see if that helped. Unfortunately, now I get a segfault every single time, except not in training, but on adding entity types.
How to reproduce the behaviour
Follow the spaCy/examples/training/train_new_entity_type.py example with the existing model 'en'. Segmentation fault occurs when adding a new entity label (ner.add_label(label)).
Your Environment
I've attached the segfault log.
segfault.txt
The text was updated successfully, but these errors were encountered: