Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add pattern validation to EntityRuler #4069

Closed
adrianeboyd opened this issue Aug 2, 2019 · 1 comment
Closed

Add pattern validation to EntityRuler #4069

adrianeboyd opened this issue Aug 2, 2019 · 1 comment
Labels
enhancement Feature requests and improvements feat / matcher Feature: Token, phrase and dependency matcher help wanted (easy) Contributions welcome! (also suited for spaCy beginners) help wanted Contributions welcome!

Comments

@adrianeboyd
Copy link
Contributor

Feature description

I think EntityRuler should have a validate option (or something like validate_patterns, if you want to keep validate for something more local) that's passed to Matcher and PhraseMatcher. Otherwise it's easy to create buggy patterns with EntityRuler and there's no simple way to check.

Related: #4063
@ines ines added enhancement Feature requests and improvements feat / matcher Feature: Token, phrase and dependency matcher help wanted Contributions welcome! help wanted (easy) Contributions welcome! (also suited for spaCy beginners) labels Aug 2, 2019
This was referenced Aug 2, 2019
Closed
Merged
@ines ines closed this as completed Aug 7, 2019
@lock
Copy link

lock bot commented Sep 6, 2019

This thread has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.

@lock lock bot locked as resolved and limited conversation to collaborators Sep 6, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
enhancement Feature requests and improvements feat / matcher Feature: Token, phrase and dependency matcher help wanted (easy) Contributions welcome! (also suited for spaCy beginners) help wanted Contributions welcome!
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@adrianeboyd @ines