Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

calling sents() on empty string #411

Closed
nartz opened this issue Jun 7, 2016 · 2 comments
Closed

calling sents() on empty string #411

nartz opened this issue Jun 7, 2016 · 2 comments
Labels
bug Bugs and behaviour differing from documentation

Comments

@nartz
Copy link

nartz commented Jun 7, 2016

I guess it was unexpected to get this error:
[s for s in nlp(u'').sents] -> IndexError: list index out of range

I.e. calling sents on an empty string errors out - I wonder if this is the right behavior, or if sents should return an empty array?

@syllog1sm syllog1sm added the bug Bugs and behaviour differing from documentation label Sep 7, 2016
@syllog1sm
Copy link
Contributor

Thanks.

This should either return an empty list or yield out of an empty generator (off the top of my head, I don't remember whether .sents is a generator...Which is probably a bad sign. =/)

@honnibal honnibal added this to the Version 1.0 Release milestone Sep 21, 2016
@lock
Copy link

lock bot commented May 9, 2018

This thread has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.

@lock lock bot locked as resolved and limited conversation to collaborators May 9, 2018
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
bug Bugs and behaviour differing from documentation
Projects
None yet
Development

No branches or pull requests

3 participants