Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

GoldParse.__init__ arguments different from GoldParse.from_annot_tuples #4463

Closed
jessecoleman opened this issue Oct 18, 2019 · 2 comments · Fixed by #4466
Closed

GoldParse.__init__ arguments different from GoldParse.from_annot_tuples #4463

jessecoleman opened this issue Oct 18, 2019 · 2 comments · Fixed by #4466
Labels
bug Bugs and behaviour differing from documentation training Training and updating models

Comments

@jessecoleman
Copy link

jessecoleman commented Oct 18, 2019 •
edited
Loading

How to reproduce the behaviour

in gold.pyx#L539 it appears as if the static from_annot_tuples function unpacks a tuple of length 7, but in the constructor gold.pyx#L635, self.orig_annot is populated with a length 6 tuple (discarding the cat annotation). This is creating a bug in the scorer.py score function where the gold object is reconstructed with from_annot_tuples function. I discovered this bug when trying to override the cli train function.

Your Environment

  • Operating System: Ubuntu 16.04.6 LTS
  • Python Version Used: 3.6.8
  • spaCy Version Used: 2.2.1
  • Environment Information: N/A
@adrianeboyd adrianeboyd added bug Bugs and behaviour differing from documentation training Training and updating models labels Oct 18, 2019
@adrianeboyd
Copy link
Contributor

Thanks for the report! I must have missed this spot when adding cats in 2.2 and I'll look into it...

@adrianeboyd adrianeboyd mentioned this issue Oct 18, 2019
Merged
3 tasks
@lock
Copy link

lock bot commented Dec 10, 2019

This thread has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.

@lock lock bot locked as resolved and limited conversation to collaborators Dec 10, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
bug Bugs and behaviour differing from documentation training Training and updating models
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Add missing cats to gold annot_tuples in Scorer adrianeboyd/spaCy
2 participants
@jessecoleman @adrianeboyd