EntityLinker predict function loops through ents instead of sents

[lilysikes]

The predict function loops through ents twice instead of looping through the sents. The code should be

for sent in doc.sents:
                    sent_doc = sent.as_doc()
                    # currently, the context is the same for each entity in a sentence (should be refined)
                    sentence_encoding = self.model([sent_doc])[0]
                    xp = get_array_module(sentence_encoding)
                    sentence_encoding_t = sentence_encoding.T
                    sentence_norm = xp.linalg.norm(sentence_encoding_t) ...

[adrianeboyd]

Thanks, that does look like a bug!

[svlandeg]

Oh wow, good catch, thanks !

[lilysikes]

No problem!

[lock]

This thread has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.