Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

cythonize subprocess calls should use calling environment #791

Closed
timkpaine opened this issue Jan 31, 2017 · 4 comments
Closed

cythonize subprocess calls should use calling environment #791

timkpaine opened this issue Jan 31, 2017 · 4 comments
Labels
bug Bugs and behaviour differing from documentation install Installation issues

Comments

@timkpaine
Copy link

Summary:
If the environment variables differ between process and subprocess, cythonize can call incorrect version of cython. To repro/see why its an issue, try to build spaCy in a 32bit virtual environment with a 64bit system python. Subprocess calls will use 64bit python rather than 32bit python.

Steps to resolve:
subprocess calls in cythonize should use shell=True, env=os.environ args.

I can do a pull request if this is something you think should be done. Otherwise the code works fine when patched manually for my install.

Environment:
Python 2.7, Windows 7, spaCy v1.6.0
64bit system python with 32bit virtual environment

@timkpaine timkpaine changed the title cythonize subprocess calls should inherit calling environment cythonize subprocess calls should use calling environment Jan 31, 2017
@honnibal
Copy link
Member

!!

So that's what's been going on. Awesome work. Yes, please write the PR!

@ines ines added bug Bugs and behaviour differing from documentation install Installation issues labels Jan 31, 2017
@timkpaine
Copy link
Author

Will do

@timkpaine
Copy link
Author

Thanks!

@lock
Copy link

lock bot commented May 9, 2018

This thread has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.

@lock lock bot locked as resolved and limited conversation to collaborators May 9, 2018
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
bug Bugs and behaviour differing from documentation install Installation issues
Projects
None yet
Development

No branches or pull requests

3 participants