-
-
Notifications
You must be signed in to change notification settings - Fork 4.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
cythonize subprocess calls should use calling environment #791
Comments
timkpaine
changed the title
cythonize subprocess calls should inherit calling environment
cythonize subprocess calls should use calling environment
Jan 31, 2017
!! So that's what's been going on. Awesome work. Yes, please write the PR! |
ines
added
bug
Bugs and behaviour differing from documentation
install
Installation issues
labels
Jan 31, 2017
Will do |
honnibal
added a commit
that referenced
this issue
Feb 16, 2017
Thanks! |
This thread has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Summary:
If the environment variables differ between process and subprocess, cythonize can call incorrect version of cython. To repro/see why its an issue, try to build spaCy in a 32bit virtual environment with a 64bit system python. Subprocess calls will use 64bit python rather than 32bit python.
Steps to resolve:
subprocess calls in cythonize should use shell=True, env=os.environ args.
I can do a pull request if this is something you think should be done. Otherwise the code works fine when patched manually for my install.
Environment:
Python 2.7, Windows 7, spaCy v1.6.0
64bit system python with 32bit virtual environment
The text was updated successfully, but these errors were encountered: