Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Convert properties to decorator syntax #13390

Merged
merged 1 commit into from
Apr 16, 2024

Conversation

JoeSchiff
Copy link
Contributor

Description

spaCy uses a legacy syntax for defining properties in a Cython extension class which has been deprecated since ~2016:
https://cython.readthedocs.io/en/stable/src/userguide/extension_types.html#properties

Switching to the new syntax required moving the property docstrings. Previously, the docstring was placed on the line below the property keyword. However, using the new syntax there can not be anything between the decorator and the def statement, so the docstring was moved to below the def statement.

Types of change

Syntax change only

Checklist

  • [X ] I confirm that I have the right to submit this contribution under the project's MIT license.
  • [X ] I ran the tests, and all new and existing tests passed.
  • [X ] My changes don't require a change to the documentation, or if they do, I've added all required information.

@svlandeg svlandeg added the meta Meta topics, e.g. repo organisation and issue management label Mar 25, 2024
@svlandeg svlandeg marked this pull request as draft March 25, 2024 12:52
@JoeSchiff JoeSchiff marked this pull request as ready for review March 31, 2024 13:24
@honnibal honnibal merged commit 2e96797 into explosion:master Apr 16, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
meta Meta topics, e.g. repo organisation and issue management
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants