Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

💫 Make like_num work for prefixed numbers #2808

Merged
merged 3 commits into from
Oct 1, 2018
Merged

💫 Make like_num work for prefixed numbers #2808

merged 3 commits into from
Oct 1, 2018

Conversation

ines
Copy link
Member

@ines ines commented Sep 27, 2018

Resolves #2782.

Description

  • only split + prefix if not followed by numbers
  • make like_num return True for numbers prefixed by +, -, ~ and ±
  • add tests

Types of change

enhancement

Checklist

  • I have submitted the spaCy Contributor Agreement.
  • I ran the tests, and all new and existing tests passed.
  • My changes don't require a change to the documentation, or if they do, I've added all required information.

@ines ines added enhancement Feature requests and improvements lang / all Global language data feat / tokenizer Feature: Tokenizer labels Sep 27, 2018
@ines ines requested a review from honnibal September 28, 2018 11:58
@honnibal honnibal merged commit ea20b72 into develop Oct 1, 2018
@ines ines deleted the feature/improve-like-num branch October 13, 2018 22:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@honnibal honnibal Awaiting requested review from honnibal

Assignees
No one assigned
Labels
enhancement Feature requests and improvements feat / tokenizer Feature: Tokenizer lang / all Global language data
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@ines @honnibal