Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

💫 Tidy up and auto-format tests #2967

Merged
merged 9 commits into from
Nov 27, 2018
Merged

💫 Tidy up and auto-format tests #2967

merged 9 commits into from
Nov 27, 2018

Conversation

ines
Copy link
Member

@ines ines commented Nov 26, 2018 •
edited
Loading

Description

  • Use black for auto-formatting
  • Remove unused imports
  • Resolve duplicate test function names
  • Make tests compatible with pytest 4.0

Types of change

tests

Checklist

  • I have submitted the spaCy Contributor Agreement.
  • I ran the tests, and all new and existing tests passed.
  • My changes don't require a change to the documentation, or if they do, I've added all required information.

@ines ines added tests New, missing or incorrect tests 🌙 nightly Discussion and contributions related to nightly builds labels Nov 26, 2018
@ines
Only use fixture via arguments
df28814 
Fixes pytest 4.0 compatibility
@honnibal honnibal merged commit b6e9914 into develop Nov 27, 2018
@ines ines deleted the chore/tidy-up-tests branch November 28, 2018 22:38
This was referenced Jun 29, 2021
Open
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
🌙 nightly Discussion and contributions related to nightly builds tests New, missing or incorrect tests
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@ines @honnibal