docs: Added missing cosine declaration #3
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* Added missing cosine declaration to code listing that already included imports for `dot` and `norm` function it uses. Signed-off-by: mr.Shu <[email protected]>
|
Thanks! |
|
@honnibal may I ask why did you just close this and the other pull request? Especially with this one I thought you'd be inclined to merge it in. Is there something wrong with it? |
|
Argh. I was supposed to merge. I thought I'd merged it, and then I also On Mon, Jan 26, 2015 at 4:25 AM, Marek Šuppa [email protected]
|
honnibal
added a commit
that referenced
this pull request
Jan 25, 2015
docs: Added missing cosine declaration
shadeMe
added a commit
to shadeMe/spaCy
that referenced
this pull request
Jan 20, 2023
* Add `TrainablePipe.{distill,get_teacher_student_loss}`
This change adds two methods:
- `TrainablePipe::distill` which performs a training step of a
student pipe on a teacher pipe, giving a batch of `Doc`s.
- `TrainablePipe::get_teacher_student_loss` computes the loss
of a student relative to the teacher.
The `distill` or `get_teacher_student_loss` methods are also implemented
in the tagger, edit tree lemmatizer, and parser pipes, to enable
distillation in those pipes and as an example for other pipes.
* Link to the `distill` method from the processing pipelines doc
* Apply suggestions from code review
Co-authored-by: Madeesh Kannan <[email protected]>
* Fix type annotations and docstrings
* Doc fix
* Tagger.rehearse: check if sgd is not None
* Remove unneeded checks
* Apply suggestions from code review
Co-authored-by: Madeesh Kannan <[email protected]>
* Doc fixes
Co-authored-by: Madeesh Kannan <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
imports for
dotandnormfunction it uses.Signed-off-by: mr.Shu [email protected]
@honnibal Thanks a ton for a great library!
While reading the index document I kind of skipped the previous declarations of
cosine. It seemed strange not to find them here since the imports were already in place.