Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

💫 Allow Span to take text label #3031

Merged
merged 1 commit into from
Dec 8, 2018
Merged

💫 Allow Span to take text label #3031

merged 1 commit into from
Dec 8, 2018
+18 −3

Conversation

honnibal
Copy link
Member

@honnibal honnibal commented Dec 8, 2018 •
edited by ines
Loading

Fixes #3027.

  • Allow Span.init to take unicode values for the label argument.
  • Allow Span.label_ to be writeable.
  • I have submitted the spaCy Contributor Agreement.
  • I ran the tests, and all new and existing tests passed.
  • My changes don't require a change to the documentation, or if they do, I've added all required information.

@ines ines changed the title Allow Span to take text label. Fixes #3027 💫 Allow Span to take text label Dec 8, 2018
@ines ines added enhancement Feature requests and improvements feat / doc Feature: Doc, Span and Token objects labels Dec 8, 2018
@ines ines merged commit 2c2db0c into develop Dec 8, 2018
@ines ines deleted the feature/span-string-label branch December 8, 2018 12:08
@svlandeg svlandeg mentioned this pull request Mar 14, 2019
Merged
3 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
enhancement Feature requests and improvements feat / doc Feature: Doc, Span and Token objects
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@honnibal @ines