Set vectors.name when updating meta.json during training

[jarib]

Description

This fixes #3093 for spacy train. Still need to check if it fixes spacy package for #3067, so it's a WIP.

Types of change

Bug fix

Checklist

• I have submitted the spaCy Contributor Agreement.
• I ran the tests, and all new and existing tests passed.
• My changes don't require a change to the documentation, or if they do, I've added all required information.

[explosion-bot]

Hi @jarib, thanks for your pull request! 👍 It looks like you haven't filled in the spaCy Contributor Agreement (SCA) yet. The agrement ensures that we can use your contribution across the project. Once you've filled in the template, put it in the .github/contributors directory and add it to this pull request. If your pull request targets a branch that's not master, for example develop, make sure to submit the Contributor Agreement to the master branch. Thanks a lot!

If you've already included the Contributor Agreement in your pull request above, you can ignore this message.

[ines]

Thanks, this was quick! (And ignore the bot 😛)

Still need to check if it fixes spacy package

I think the package command generates the meta separately – so this might have to be adjusted in generate_meta here.

[ines]

Looks good – merging! 👍

[jarib]

I've added vectors.name to spacy package's meta generation and tested that it successfully packages a model with vectors.

A future improvement could be to reduce the duplication by making the model meta data into a class that adds some validation.

[rbhambriiit]

Just hit the issue in 2.0.18

One of the smallest pull request for sure :D