Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix doc.count_by functionality #3950

Merged
merged 4 commits into from
Jul 11, 2019
Merged

Fix doc.count_by functionality #3950

merged 4 commits into from
Jul 11, 2019

Conversation

svlandeg
Copy link
Member

Using Python's Counter instead of PreshCounter fixes a bug described in Issue #3869.
Added a unit test to check this behaviour.

Types of change

bug fix

Checklist

  • I have submitted the spaCy Contributor Agreement.
  • I ran the tests, and all new and existing tests passed.
  • My changes don't require a change to the documentation, or if they do, I've added all required information.

@svlandeg svlandeg added the feat / doc Feature: Doc, Span and Token objects label Jul 11, 2019
@ines ines added the bug Bugs and behaviour differing from documentation label Jul 11, 2019
@ines ines merged commit 673c864 into explosion:master Jul 11, 2019
@svlandeg svlandeg deleted the bugfix/issue-3869 branch July 11, 2019 11:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
bug Bugs and behaviour differing from documentation feat / doc Feature: Doc, Span and Token objects
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@svlandeg @ines