-
-
Notifications
You must be signed in to change notification settings - Fork 4.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Documentation for Entity Linking #4065
Conversation
# Conflicts: # examples/pipeline/wikidata_entity_linking.py # spacy/pipeline/pipes.pyx
Update: filtered this PR down and moved all functionality changes to PR #4091 --> once the latter one is merged, will merge into this to clean this up. |
# Conflicts: # bin/wiki_entity_linking/train_descriptions.py # examples/pipeline/dummy_entity_linking.py # examples/pipeline/wikidata_entity_linking.py # examples/training/pretrain_kb.py # spacy/errors.py
@ines : thanks for the review! I think I addressed everything. I was also wondering whether I should add anything to the Cython documentation (strucs & classes), or do we consider the KB too specific to be included there? |
I think for now, it's okay to not document the Cython part and consider this internals. There's a chance that some of the specifics are still going to change. The main focus of the Cython docs are the data structures that we want users to interact with directly from their Cython implementations. |
Documentation for PRs #3459, #3864 and PR #4003 - all referring to the Entity Linking functionality discussed in Issue #3339.
Added documentation
API
kb.md
(forKnowledgeBase
inkb.pyx
)candidate.md
(forCandidate
inkb.pyx
)entitylinker.md
(forEntityLinker
inpipes.pyx
)span.md
, addedkb_id
attributetoken.md
, addedent_kb_id
attributegoldparse.md
, addedlinks
attributeentityrecognizer.md
,textcategorizer.md
andtagger.md
, with more explicit references totensors
andoptimizer.averages
(to keep the docs consistent across pipe components)Usage
UPDATED:101/_named_entities.md
and101/_pipelines.md
, added explanations around KB ID fieldsprocessing-pipelines.md
, addedentity_linker
pipe explanationspacy-101.md
, added Entity Linking & Knowledge Base definitionstraining.md
with information on training the entity linker + references to the two generic example scriptslinguistic-features.md
, added explanations around Entity Linking + example codefacts-figures.md
, set support to Entity Linking to True !TODO before merging
ctrl-F "X.X" and replace with actual version number.DONEMake sure the pretrained models include theThe example scripts should work though because they start with aentity_linking
pipe so the code snippets actually work. Some of them currently don't, I tested them on custom models instead.blank
model.Types of change
Changes to the documentation
Checklist