Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixed syntax error in lang/ko when using python 2 #4082

Merged
merged 5 commits into from
Aug 5, 2019

Conversation

veer-bains
Copy link
Contributor

changed code for data typecasting from python 3 syntax to python 2 in the python 2 section

Description

changed typecasting from
surface: str
to
surface = str("")
since python 2 doesnt support typecasting with a :

Types of change

bug fix

Checklist

  • I have submitted the spaCy Contributor Agreement.
  • [] I ran the tests, and all new and existing tests passed.
  • My changes don't require a change to the documentation, or if they do, I've added all required information.

veerbains and others added 5 commits August 5, 2019 12:14
fixed syntax errors in variable datatype assignment when calling spacy.blank("ko") with python 2.7
@ines ines added bug Bugs and behaviour differing from documentation lang / ko Korean language data and models labels Aug 5, 2019
@ines
Copy link
Member

ines commented Aug 5, 2019

Thanks! 👍

@ines ines merged commit 874bd8c into explosion:master Aug 5, 2019
polm pushed a commit to polm/spaCy that referenced this pull request Aug 18, 2019
…loses explosion#4068)

* fixed syntax error in declaring variables with python 2.7 in spacy/lang/ko/__init__.py

* fixed syntax error in declaring variables with python 2.7 in spacy/lang/ko/__init__.py

* Update __init__.py

* Create veer-bains.md

* Update __init__.py

fixed syntax errors in variable datatype assignment when calling spacy.blank("ko") with python 2.7
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Bugs and behaviour differing from documentation lang / ko Korean language data and models
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants