Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update vocab.get_vector docs to include features on Fasttext ngram #4464

Merged
merged 2 commits into from
Oct 19, 2019
Merged

Update vocab.get_vector docs to include features on Fasttext ngram #4464

merged 2 commits into from
Oct 19, 2019

Conversation

pberba
Copy link
Contributor

@pberba pberba commented Oct 18, 2019

I've updated the documentation for vocab.get_vector to include changes for support of Fasttext ngrams.

Description

Although support for Fasttext ngrams have been added since spaCy v2.1, this features are not reflected in the documentation.

Types of change

Update of documentation.

Checklist

  • I have submitted the spaCy Contributor Agreement.
  • My changes don't require a change to the documentation, or if they do, I've added all required information.

@svlandeg svlandeg added the docs Documentation and website label Oct 18, 2019
@honnibal
Copy link
Member

Thanks! You're right, this was an oversight.

@honnibal honnibal merged commit 7772d5d into explosion:master Oct 19, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
docs Documentation and website
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@pberba @honnibal @svlandeg