Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The
GoldParse
init constructor has a catch-all**_
which seems to have led to a subtle bug innn_parser.pyx
.Personally I would prefer removing
**_
from the constructor, but this may break people's scripts (though the breaking might be informational). We can also remove it as part of the v.3.0 release. Unless there is a reason to keep this?Types of change
bug fix
Checklist