Add destructors for states in TransitionSystem #4686
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The tests will fail with the current version of thinc due to API differences. |
adrianeboyd
added
bug
|
Thanks! Just merged the patch to Thinc. When we're ready, we'll put up a dev release of the next version, and then we can require that dev release on this branch. If it goes green we can then release the version of Thinc, and update the requirement to the non-dev release. |
|
The dev version of Thinc should be up now. Closing and reopening to restart checks. |
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Add destructors for states in
TransitionSystemto fix memory inbeam_parse().Needs to be coordinated with the parallel modifications to thinc, see explosion/thinc#123.
Fixes #4432.
Types of change
Bugfix.
Checklist