Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Make vectors.find() return keys in correct order #4691

Merged
merged 2 commits into from
Nov 21, 2019
Merged

Make vectors.find() return keys in correct order #4691

merged 2 commits into from
Nov 21, 2019

Conversation

honnibal
Copy link
Member

vectors.find() accepts several input types. One of them is a sequence of rows, which are mapped into a sequence of corresponding keys. This function returned the keys out of order.

  • I have submitted the spaCy Contributor Agreement.
  • I ran the tests, and all new and existing tests passed.
  • My changes don't require a change to the documentation, or if they do, I've added all required information.

honnibal
honnibal commented Nov 21, 2019
View reviewed changes
spacy/vectors.pyx Outdated Show resolved Hide resolved
@ines ines added bug Bugs and behaviour differing from documentation feat / vectors Feature: Word vectors and similarity labels Nov 21, 2019
@ines ines merged commit 50f89cb into master Nov 21, 2019
@ines ines deleted the bugfix/vectors-find branch November 21, 2019 15:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
bug Bugs and behaviour differing from documentation feat / vectors Feature: Word vectors and similarity
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@honnibal @ines