Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Auto-exclude disabled when calling from_disk during load #4708

Merged
merged 1 commit into from
Nov 25, 2019
Merged

Auto-exclude disabled when calling from_disk during load #4708

merged 1 commit into from
Nov 25, 2019

Conversation

ines
Copy link
Member

@ines ines commented Nov 25, 2019

Fixes #4707.

Description

When you disable a component when loading a model, it should also be excluded when calling nlp.from_disk afterwards to load the individual components (especially the tokenizer, which will otherwise raise an error).

Types of change

bug fix

Checklist

  • I have submitted the spaCy Contributor Agreement.
  • I ran the tests, and all new and existing tests passed.
  • My changes don't require a change to the documentation, or if they do, I've added all required information.

@ines ines added bug Bugs and behaviour differing from documentation feat / serialize Feature: Serialization, saving and loading labels Nov 25, 2019
@honnibal honnibal merged commit 5b36dec into master Nov 25, 2019
@ines ines deleted the fix/exclude-disabled-from-disk branch July 6, 2020 12:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
bug Bugs and behaviour differing from documentation feat / serialize Feature: Serialization, saving and loading
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

load_model_from_path does not pass through the list of Exclude
2 participants
@ines @honnibal