Sync Span __eq__ and __hash__ #5005
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Use the same tuple for `__eq__` and `__hash__`, including all attributes except `vector` and `vector_norm`.
svlandeg
added
bug
Update `assert_docs_equal()` test util to compare `Span` properties for ents rather than `Span` objects.
adrianeboyd
added a commit
to adrianeboyd/spaCy
that referenced
this pull request
Mar 13, 2020
Due to changes to `Span` (explosion#5005), spans from different documents are now never equal. Check `Token.is_sent_start` values instead.
3 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Use the same tuple for
__eq__and__hash__, including all attributes exceptvectorandvector_norm.Fixes #4965.
Types of change
Checklist