Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Raise error for inplace resize with new vector dim #5228

Merged
merged 1 commit into from
Apr 2, 2020
Merged

Raise error for inplace resize with new vector dim #5228

merged 1 commit into from
Apr 2, 2020

Conversation

adrianeboyd
Copy link
Contributor

Description

Raise an error if there is an attempt to resize the vectors in place with
a different vector dimension.

Types of change

Bug fix.

Checklist

  • I have submitted the spaCy Contributor Agreement.
  • I ran the tests, and all new and existing tests passed.
  • My changes don't require a change to the documentation, or if they do, I've added all required information.

@adrianeboyd
Raise error for inplace resize with new vector dim
e76039f 
Raise an error if there is an attempt to resize the vectors in place with
a different vector dimension.
@adrianeboyd adrianeboyd added bug Bugs and behaviour differing from documentation feat / vectors Feature: Word vectors and similarity labels Mar 30, 2020
@honnibal honnibal merged commit d107afc into explosion:master Apr 2, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
bug Bugs and behaviour differing from documentation feat / vectors Feature: Word vectors and similarity
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@adrianeboyd @honnibal