Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Prevent pip from installing spaCy on Python 3.4 #5344

Merged
merged 1 commit into from
Apr 27, 2020
Merged

Prevent pip from installing spaCy on Python 3.4 #5344

merged 1 commit into from
Apr 27, 2020

Conversation

michael-k
Copy link
Contributor

Description

Prevent pip from installing spaCy on Python 3.4 (which is unsupported since v2.2.0) by extending python_requires.

Missed in 80d554f

Types of change

enhancement

Checklist

  • I have submitted the spaCy Contributor Agreement.
  • I ran the tests, and all new and existing tests passed.
  • My changes don't require a change to the documentation, or if they do, I've added all required information.

@svlandeg svlandeg added the install Installation issues label Apr 23, 2020
@svlandeg
Copy link
Member

Thanks for the fix, very much appreciated !

@svlandeg svlandeg merged commit 5b5528f into explosion:master Apr 27, 2020
@svlandeg svlandeg added the enhancement Feature requests and improvements label Apr 27, 2020
@michael-k michael-k deleted the py3.4 branch April 28, 2020 11:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
enhancement Feature requests and improvements install Installation issues
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@michael-k @svlandeg