Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

prevent None in gold fields #5425

Merged
merged 2 commits into from
May 13, 2020
Merged

prevent None in gold fields #5425

merged 2 commits into from
May 13, 2020

Conversation

svlandeg
Copy link
Member

cf Issue #5181 (which discusses two bugs, so shouldn't be closed just yet)

Description

If a training text was empty, gold.ner was None, throwing an error when training the NER pipeline

Types of change

bug fix

Checklist

  • I have submitted the spaCy Contributor Agreement.
  • I ran the tests, and all new and existing tests passed.
  • My changes don't require a change to the documentation, or if they do, I've added all required information.

@svlandeg svlandeg added bug Bugs and behaviour differing from documentation feat / ner Feature: Named Entity Recognizer training Training and updating models labels May 11, 2020
@svlandeg svlandeg mentioned this pull request May 11, 2020
Closed
@honnibal honnibal merged commit b047389 into explosion:master May 13, 2020
@svlandeg svlandeg deleted the bugfix/prevent-empty-gold branch May 13, 2020 20:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
bug Bugs and behaviour differing from documentation feat / ner Feature: Named Entity Recognizer training Training and updating models
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@svlandeg @honnibal