Fix ErrorsWithCodes().__class__ return value #5436
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Fix
ErrorsWithCodes().__class__
value - it should be a class rather than a string like"[__class__] .."
before.It's critical for functions which try to inference the class of an object, i.e.
isinstance
I personally encountered the issue using
rollbar
which collects all the visible variables and tries to serialize those. In case of ErrorsWithCodes() it failed duringisinstance(o, collections.abc.Mapping)
check.I ran all the tests using Python 3.8, Ubuntu 19.04, no spacy models preinstalled.
spacy
is installed withpip install -e path_to_repo
.*The failed test case fails without my change too
Types of change
A bug fix
Checklist