Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Preserve _SP when filtering tag map in Tagger #5527

Merged
merged 1 commit into from
Jun 1, 2020

Conversation

adrianeboyd
Copy link
Contributor

Description

To allow "SP" as a tag (for Chinese OntoNotes), preserve "_SP" if present as the reference SPACE POS in the tag map in Tagger.begin_training().

Types of change

Bug fix.

Checklist

  • I have submitted the spaCy Contributor Agreement.
  • I ran the tests, and all new and existing tests passed.
  • My changes don't require a change to the documentation, or if they do, I've added all required information.

To allow "SP" as a tag (for Chinese OntoNotes), preserve "_SP" if
present as the reference `SPACE` POS in the tag map in
`Tagger.begin_training()`.
@adrianeboyd adrianeboyd added bug Bugs and behaviour differing from documentation feat / tagger Feature: Part-of-speech tagger labels May 31, 2020
@honnibal honnibal merged commit 67af3a3 into explosion:master Jun 1, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Bugs and behaviour differing from documentation feat / tagger Feature: Part-of-speech tagger
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants