Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fixing reproducible training #5735

Merged
merged 7 commits into from
Jul 9, 2020
Merged

Fixing reproducible training #5735

merged 7 commits into from
Jul 9, 2020

Conversation

svlandeg
Copy link
Member

@svlandeg svlandeg commented Jul 9, 2020 •
edited
Loading

Description

Testing reproducibility for Tok2Vec and textcat - this works when hard-coding the seeds for the HashEmbed layers.

Fixes #5551

Types of change

bug fix

Checklist

  • I have submitted the spaCy Contributor Agreement.
  • I ran the tests, and all new and existing tests passed.
  • My changes don't require a change to the documentation, or if they do, I've added all required information.

@svlandeg svlandeg added bug Bugs and behaviour differing from documentation training Training and updating models ⚠️ wip Work in progress labels Jul 9, 2020
@svlandeg svlandeg marked this pull request as draft July 9, 2020 12:49
@svlandeg svlandeg mentioned this pull request Jul 9, 2020
Closed
@svlandeg svlandeg removed the ⚠️ wip Work in progress label Jul 9, 2020
@svlandeg svlandeg marked this pull request as ready for review July 9, 2020 15:54
@honnibal honnibal merged commit c1ea553 into develop Jul 9, 2020
honnibal added a commit that referenced this pull request Jul 9, 2020
@honnibal
Revert "Fixing reproducible training (#5735)"
61f8f11 
This reverts commit c1ea553.
@svlandeg svlandeg deleted the bugfix/reproducible-training branch July 9, 2020 20:23
@svlandeg svlandeg mentioned this pull request Jul 9, 2020
Closed
@svlandeg svlandeg linked an issue Jul 9, 2020 that may be closed by this pull request
Training baseline scores vary despite random seeds fixed #5551
Closed
@svlandeg svlandeg restored the bugfix/reproducible-training branch July 10, 2020 11:52
@svlandeg svlandeg deleted the bugfix/reproducible-training branch July 30, 2020 11:55
@adrianeboyd adrianeboyd mentioned this pull request Oct 2, 2020
Closed
@svlandeg svlandeg added the v3.0 Related to v3.0 label Oct 7, 2020
@svlandeg svlandeg mentioned this pull request Oct 7, 2020
Merged
3 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
bug Bugs and behaviour differing from documentation training Training and updating models v3.0 Related to v3.0
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Training baseline scores vary despite random seeds fixed
2 participants
@svlandeg @honnibal