Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rename pipe to CuratedTransformer #12

Merged
merged 1 commit into from
Jul 21, 2023

Conversation

shadeMe
Copy link
Collaborator

@shadeMe shadeMe commented Jul 20, 2023

Description

This needs to be done in order to distinguish this pipe from the TrainablePipe implemented in spacy-transformers (which is also called Transformer).

After merging, we'll need to publish a new minor release and retrain the models.

Types of change

Refactor

Checklist

  • I confirm that I have the right to submit this contribution under the project's MIT license.
  • I ran the tests, and all new and existing tests passed.
  • My changes don't require a change to the documentation, or if they do, I've added all required information.

@danieldk danieldk merged commit 3c6765b into explosion:main Jul 21, 2023
6 checks passed
@shadeMe shadeMe deleted the refactor/rename-pipe branch July 21, 2023 06:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants