Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rebase on curated-transformers 2.0.0 #19

Merged
merged 17 commits into from
Apr 9, 2024

Conversation

shadeMe
Copy link
Collaborator

@shadeMe shadeMe commented Aug 9, 2023

Description

This PR rebases the project on curated-transformers 1.0.0. This is a breaking change - spaCy pipelines trained with previous versions will not be compatible due to changes to parameter names, etc.

The piece encoder/tokenizer implementations remain untouched (except for a minor fix) for the time being since the serialization contract is currently undetermined on the curated-transformers side.

Types of change

Maintenance

Checklist

  • I confirm that I have the right to submit this contribution under the project's MIT license.
  • I ran the tests, and all new and existing tests passed.
  • My changes don't require a change to the documentation, or if they do, I've added all required information.

@shadeMe shadeMe changed the base branch from main to rebase-on-ct-1.0.0 August 9, 2023 13:46
@adrianeboyd
Copy link
Contributor

I'm worried that this may cause the same kinds of headaches as spacy-transformers v1.3.0. The only info we have in saved pipeline directories is which spacy version they were trained with, the versioning for spacy-transformers or spacy-curated-transformers is only included by spacy package.

@adrianeboyd
Copy link
Contributor

It's nothing against this PR, just potentially a concern about publishing anything that uses earlier versions, such as the trf pipelines that have been published for spacy v3.7.0.dev0.

@shadeMe shadeMe changed the base branch from rebase-on-ct-1.0.0 to 0.3.0 August 23, 2023 11:07
@shadeMe shadeMe marked this pull request as draft August 25, 2023 09:05
@danieldk danieldk changed the base branch from 0.3.0 to v4 February 7, 2024 08:38
@danieldk danieldk force-pushed the refactor/rebase-on-ct-1.x.x branch from 6639cb6 to 14b0814 Compare April 8, 2024 13:16
@danieldk danieldk changed the title Rebase on curated-transformers 1.0.0 Rebase on curated-transformers 2.0.0 Apr 8, 2024
@danieldk danieldk marked this pull request as ready for review April 8, 2024 15:31
@danieldk
Copy link
Contributor

danieldk commented Apr 8, 2024

Copy link
Collaborator Author

@shadeMe shadeMe left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Just one small comment.

Copy link
Member

@svlandeg svlandeg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@danieldk danieldk merged commit 4d8ccb4 into explosion:v4 Apr 9, 2024
7 of 8 checks passed
@shadeMe shadeMe deleted the refactor/rebase-on-ct-1.x.x branch April 9, 2024 09:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants