Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Raise an error when piece encoders are called before initialization #21

Merged
merged 4 commits into from
Aug 23, 2023
Merged

Raise an error when piece encoders are called before initialization #21

merged 4 commits into from
Aug 23, 2023

Conversation

shadeMe
Copy link
Collaborator

@shadeMe shadeMe commented Aug 10, 2023 •
edited
Loading

This change will break existing models, so we'll target v0.3.0.

Types of change

Enhancement

Checklist

  • I confirm that I have the right to submit this contribution under the project's MIT license.
  • I ran the tests, and all new and existing tests passed.
  • My changes don't require a change to the documentation, or if they do, I've added all required information.

@shadeMe shadeMe added the enhancement New feature or request label Aug 10, 2023
@shadeMe shadeMe changed the base branch from main to 0.3.0 August 23, 2023 11:08
@svlandeg svlandeg merged commit 4d0cb73 into 0.3.0 Aug 23, 2023
14 checks passed
@svlandeg svlandeg deleted the feat/error-msg-uninit-tokenizer branch August 23, 2023 15:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@svlandeg svlandeg svlandeg left review comments

Assignees
No one assigned
Labels
enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@shadeMe @svlandeg