GradScaler: Do not enable when training on CPU #623
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Disable gradient scaling and emit a warning when but CPU training is performed. - Disable gradient scaling and emit a warning when a PyTorch version without gradient scaling is used (rather than raising an exception). See #10527
danieldk
force-pushed
the
disable-gradscaler-without-cuda
branch
from
467e95a
to
6c6463c
Compare
|
This turns out to be quite tricky, since Thinc may not be switched to GPU yet when I will close this PR in favor of #624, which replaces the assertion by an exception and describes how this error can be avoided. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
performed.
without gradient scaling is used (rather than raising an exception).
See explosion/spaCy#10527
Note: putting this in draft. I'd like to add a similar check and warning to the shim.