Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Revert uninit'd allocs in Numpy.reduce_max introduced in #632. #636

Merged
merged 4 commits into from
Apr 21, 2022
Merged

Revert uninit'd allocs in Numpy.reduce_max introduced in #632. #636

merged 4 commits into from
Apr 21, 2022

Conversation

shadeMe
Copy link
Collaborator

@shadeMe shadeMe commented Apr 19, 2022

This change broke spancat tests in the spaCy test suite.

@shadeMe shadeMe requested a review from svlandeg April 19, 2022 11:02
@shadeMe shadeMe mentioned this pull request Apr 19, 2022
Closed
@shadeMe shadeMe marked this pull request as ready for review April 19, 2022 11:03
@shadeMe shadeMe added bug Bugs and behaviour differing from documentation feat / ops Backends and maths labels Apr 19, 2022
@shadeMe shadeMe requested a review from danieldk April 19, 2022 15:52
svlandeg
svlandeg approved these changes Apr 20, 2022
View reviewed changes
Copy link
Member

@svlandeg svlandeg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good!

@svlandeg svlandeg merged commit fb92135 into explosion:develop Apr 21, 2022
@shadeMe shadeMe deleted the revert-uninit-alloc branch April 25, 2022 17:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@danieldk danieldk danieldk approved these changes

@svlandeg svlandeg svlandeg approved these changes

Assignees
No one assigned
Labels
bug Bugs and behaviour differing from documentation feat / ops Backends and maths
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@shadeMe @danieldk @svlandeg