Remove vestigial/mostly unused backends.linalg module
#742
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
3 tasks
danieldk
reviewed
Aug 29, 2022
|
@explosion-bot please test_slow_gpu |
URL: https://buildkite.com/explosion-ai/thinc-slow-gpu-tests/builds/30 |
|
@explosion-bot please test_slow_gpu |
URL: https://buildkite.com/explosion-ai/thinc-slow-gpu-tests/builds/32 |
danieldk
approved these changes
Sep 13, 2022
|
Seems like the test failure on Windows 3.10 is spurious? |
shadeMe
added a commit
to shadeMe/thinc
that referenced
this pull request
Jan 5, 2023
* `CBlas`: Add `sscalv` * `NumpyOps`: Replace usage of `.linalg` with `numpy` and `BLAS` calls * Remove vestigial/mostly unused `backends.linalg` module * Use BLAS notation for `sscal`, add `dscal`
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The
backends.linalgmodule was introduced back in 2016, presumably as a BLAS-specific implementation of linear algebra functions that could be used in the context of thinc ops. In the current version of thinc, however, this module is almost entirely unused (and untested), where calls to its functions have been replaced by their more performant equivalents innumpy/cupy.This PR replaces the last remaining references to the module's functions with
numpyandBLAScalls and removes it from the project.Outside of thinc, this module was only used in the transition-based paser code in spaCy. This spaCy PR replaces those references in a similar fashion.