Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add missing packaging requirement #799

Merged
merged 2 commits into from
Oct 27, 2022
Merged

Add missing packaging requirement #799

merged 2 commits into from
Oct 27, 2022

Conversation

adrianeboyd
Copy link
Contributor

  • Test import thinc before dev requirements are installed.
  • Add requirement for packaging.

@adrianeboyd
Add simple import test
9514221 
Test `import thinc` before dev requirements are installed.
@adrianeboyd adrianeboyd marked this pull request as draft October 27, 2022 12:43
@adrianeboyd
Copy link
Contributor Author

This should initially fail, then I will actually add the packaging requirement.

@adrianeboyd adrianeboyd marked this pull request as ready for review October 27, 2022 12:48
@adrianeboyd adrianeboyd merged commit e950fbf into explosion:master Oct 27, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@adrianeboyd