Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[eas-cli] remove @expo/config-types dependency #2528

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

szdziedzic
Copy link
Member

@szdziedzic szdziedzic commented Sep 2, 2024

Why

Rely on ExpoConfig type from the @expo/config package in all places for consistency

How

Rely on ExpoConfig type from the @expo/config package in all places for consistency

Test Plan

Tests

Copy link

github-actions bot commented Sep 2, 2024

❌ It looks like a changelog entry is missing for this PR. You have two options: you can add it manually, or you can use the changelog bot to do it for you.
🤖 To use the bot, simply comment on this PR with the command /changelog-entry [breaking-change|new-feature|bug-fix|chore] [message].
⏩ If this PR doesn't require a changelog entry, such as if it's an internal change that doesn't affect the user experience, you can add the "no changelog" label to the PR.

@szdziedzic szdziedzic marked this pull request as ready for review September 2, 2024 16:15
Copy link

github-actions bot commented Sep 2, 2024

Size Change: -1.81 kB (0%)

Total Size: 52.3 MB

Filename Size Change
./packages/eas-cli/dist/eas-linux-x64.tar.gz 52.3 MB -1.81 kB (0%)

compressed-size-action

Copy link

codecov bot commented Sep 2, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 52.59%. Comparing base (f31054c) to head (82304e9).

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #2528   +/-   ##
=======================================
  Coverage   52.59%   52.59%           
=======================================
  Files         548      548           
  Lines       20409    20409           
  Branches     4163     4163           
=======================================
  Hits        10732    10732           
  Misses       8837     8837           
  Partials      840      840           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@szdziedzic szdziedzic changed the title [eas-cli] remove @expo-config-types dependency [eas-cli] remove @expo/config-types dependency Sep 2, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants