deps: [email protected] #115
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Seing that the mocha and cookie packages has a vulnerability on older versions, i decided to upgraded the packages to remove the vulnerabilities, and decided to change the version text adding a "^" so that in the future, new updates of this packages will be installed instead of a fixed version, it may be better to use "~" for only bug fixes
|
Hey @masterkey-07! Thanks for creating this PR and helping the project ❤️ Can you create a new PR or recycle this one just for mocha upgrade? Currently cookie was upgraded in https://www.npmjs.com/package/cookie-parser/v/1.4.7, also regarding caret there is an open discussion in expressjs/discussions#279. I prefer anchored versions until we have a consensus on the caret policy 😉 |
|
Hi @UlisesGascon! I made the change only for the mocha package, but it still has the caret. |
UlisesGascon
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Seing that the mocha and cookie packages has a vulnerability on older versions, i decided to upgraded the packages to remove the vulnerabilities, and decided to change the version text adding a "^" so that in the future, new updates of this packages will be installed instead of a fixed version, it may be better to use "~" for only bug fixes.