Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Express 5.0 - last push! #233

Closed
31 of 46 tasks
UlisesGascon opened this issue Apr 24, 2024 · 24 comments
Closed
31 of 46 tasks

Express 5.0 - last push! #233

UlisesGascon opened this issue Apr 24, 2024 · 24 comments
Labels
tc agenda top priority Issues which the TC deem our current highest priorities for the project

Comments

@UlisesGascon
Copy link
Member

UlisesGascon commented Apr 24, 2024

This issue includes a reference to all the PRs/issues or pending tasks for Express and dependencies needed to finally ship Express@5.

Rules (WIP):

  • If something is completed, just marked
  • If there is a PR/Issue/Discussion please add it (try to use one item)
  • If there is someone taking ownership on it, please add it. Ownership means to be the focal point for it not necessarily the person who makes the final change.
  • If there is no leader, feel free to claim it.
  • If you can no longer lead something, just let others claim it back
  • As this issue can have many comments, feel free to address them and then mark the original comment as "outdated" (details) so it is easier to follow.

If you think that any reference is missing, please edit this comment (@expressjs/express-tc) or reply with a comment if you don't have the permissions.

Pending things (Express):

Pending things (Dependencies):

Pending things (Documentation):

Discussions pending:

New

Under Investigation

Decisions made:

Not in 5.x

Future Minors

@UlisesGascon UlisesGascon pinned this issue Apr 24, 2024
This was referenced Apr 24, 2024
@UlisesGascon UlisesGascon added top priority Issues which the TC deem our current highest priorities for the project tc agenda labels Apr 25, 2024
@wesleytodd

This comment was marked as outdated.

@UlisesGascon

This comment was marked as outdated.

@CBID2

This comment was marked as outdated.

@wesleytodd
Copy link
Member

Yeah this is great! Absolutely agree with getting folks involved in taking ownership of them. Go team!

If anything is missing from dependencies, please feel free to add them.

Ok yeah this was my main concern. I knew for sure there is router stuff which is why I started there with the labels, but I think there is more in the other few. So if anyone wants to take point on reviewing the deps we own which are "direct deps" of express that would be awesome. Specifically I think each repo needs to address if there are any pending breaking changes which look like they were ready to land (if they are too contentious or too incomplete then we should not land them now) or if there is a pre-existing major version branch with work left to do on it (which is the case in a few for sure). For that we need to catalog that work here so we make sure we don't miss anything.

@jonchurch

This comment was marked as resolved.

@mertcanaltin

This comment was marked as outdated.

@mertcanaltin

This comment was marked as outdated.

@UlisesGascon
Copy link
Member Author

Can I do the "Add the blog one" @UlisesGascon?

I think that @chrisdel101 is actively working on it, maybe we can provide them more support.

Aside of active development for sure you (@CBID2 @mertcanaltin) can work on:

Add support for Node@22 in the CI (no leader), would like to work with this topic.

I think that maybe @rxmarbles is working on it, based on slack comment

@wesleytodd
Copy link
Member

Active dev branch for v5 is 5.x, correct? As opposed to 5.0 which would be a release branch?

Yeah exactly. That said I have gotten confused a few times and I think this is one case where we would benefit from automation and some really clear and simple docs.

@Yaminyam

This comment was marked as off-topic.

@wesleytodd

This comment was marked as off-topic.

@wesleytodd
Copy link
Member

wesleytodd commented May 15, 2024

@jonchurch do you think this needs to be added to the list above? expressjs/express#4851

EDIT: just to keep the records, this one is related as well I think expressjs/express#4852

@wesleytodd
Copy link
Member

I reviewed the remaining open things in body-parser. I added them to the list here, but likely will want to update the linked v2 PR as well. I dont have enough remaining battery on this plane to be able to start work on them, and also I think some are a bit ambigious as to what we need to do to get it across the finish line. Would love if folks could click through some of the ones I added and add any insight or thoughts they have on them and if we need to land them.

@jdhiro

This comment was marked as abuse.

@RobinTail
Copy link

@wesleytodd , would it be possible to detach features from the breaking changes needed for those features in order to speed up the release of 5.0?

The brotli support could be a feature of 5.1, isn't it? While dropping Node versions below 18 must be prioritised to enable and ease implementing new features of 5.x.

It's been 10 years.

2024-07-03_11-30-59

@ctcpip
Copy link
Member

ctcpip commented Jul 3, 2024

A number of things have been punted from the initial 5.0 release, and more may yet be punted, where possible.

@wesleytodd
Copy link
Member

wesleytodd commented Jul 30, 2024

Ok, I just checked off an important one: "Look through the direct deps to see if they have things which need to land"

I have gone through and commented on or resolved as many of the PR's/issues/discussions in the direct and transitives which seem to have some pending (breaking) changes to land. I added a few things on the list, but they are relatively small and should be simple enough to resolve.

Which means, this is pretty much a complete final picture finally of what needs to be wrapped up to release.

@IamLizu

This comment was marked as resolved.

@kibertoad

This comment was marked as off-topic.

@wesleytodd

This comment was marked as off-topic.

wesleytodd added a commit to expressjs/express that referenced this issue Sep 10, 2024
@RobinTail
Copy link

Thank you @wesleytodd , @UlisesGascon , @ctcpip and others!
This is an epic achievement on the planetary scale.
❤️

@wesleytodd
Copy link
Member

We put a closes line in the commit, but looks like it didnt actually close this. So I can happily say this is closed as completed!

@UlisesGascon
Copy link
Member Author

I will relocate the pending things to 2 new issues (backlog for 5.x and Backlog for 6.0) :)

@UlisesGascon UlisesGascon unpinned this issue Sep 10, 2024
@UlisesGascon UlisesGascon mentioned this issue Sep 10, 2024
10 tasks
RobinTail added a commit to RobinTail/express-zod-api that referenced this issue Sep 10, 2024
Instead of #374 but non-breaking

The express 5 beta 3 is fully operational and tested by community, but
its release is delayed.
The current issue is that it's also outdated comparing to v4.18.2,
having nested dependencies of older versions.

latest tracking issue:
```
expressjs/discussions#233
```

previous one:
```
expressjs/express#5205
```

Latest proposal:
```
expressjs/discussions#160
```

Probably it will be ready in march 🤞🏽  (no, it's not)
```
expressjs/express#5111 (comment)
```
@ctcpip
Copy link
Member

ctcpip commented Sep 10, 2024

resolved via expressjs/express#2237

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
tc agenda top priority Issues which the TC deem our current highest priorities for the project
Projects
None yet
Development

No branches or pull requests