-
Notifications
You must be signed in to change notification settings - Fork 15.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Version 4.21.0 and older now pulls in types for 5.0.0 that are incompatible. #5987
Comments
Express itself does not depend on or include By the way, the types for express are maintained in the DefinitelyTyped project: |
Not sure why but the v5 types are pushed to v4.17.21 causing a lot of linting errors for me I have to pin types back to 4.17.20 for now:
|
I'm with the same issue. I would like to ask if will fix it? By the way for who are using npm this could be a solution:
otherwise can use the @Trinovantes solution for yarn |
For anyone with this issue, can you please do The v5 types were most assuredly not pushed to v4. The DT publisher knows when it's about to publish a package with the same contents and skips it. When the v5 types were published, v4 did not change and you can see in the version list only v5 getting updated:
|
@JimmyBjorklund what version range did you have for your Please follow jakebailey's steps and report back.
This would always have been necessary to guard against pulling a new major's types when they were published. The difference today is that there is a new major's types on DT |
Ah, I forgot you can use It seems there's actually a lot of broken packages:
|
"*" means "resolve to any version", it doesn't neccesarily mean "resolve to latest". They are all compatible with v4 and v5, and if we had written |
I'm using yarn 1.22.22 and it's resolving to the latest version for me |
You may have to use overrides, then. (Yarn v1 is very old and unmaintained; maybe it's just an unfixed bug 🤷) From the DT side, it's possible that using peer deps would help (once we implement support for them), but if package managers are still preferring newer versions, it may not help. |
|
Those experiencing this problem need to ensure:
CC @JimmyBjorklund @Trinovantes Example of |
they are not. |
Yea that was a misunderstanding on my part. Turns out I was using |
Version 4.21.0 and older now pulls in types for 5.0.0 that are incompatible.
Adding the types/express 4.17.21 fixes the issue but it was not needed until today
The text was updated successfully, but these errors were encountered: