Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs: list current Committers + bjohansebas nomination #6033

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

UlisesGascon
Copy link
Member

This PR list current Committers for projects.

Note: I am +1 in the nomination, he have done non-trivial contributions in the project for a while. Note that I am repo captain for compression too (#6027)

cc: @expressjs/express-tc

@UlisesGascon UlisesGascon requested a review from a team October 8, 2024 10:36
@UlisesGascon UlisesGascon self-assigned this Oct 8, 2024
@bjohansebas
Copy link
Member

Hi @UlisesGascon, I can also be part of the committee for the website. I've been helping with the site by updating its documentation and improving its design for several months now. What do you think?

cc: @crandmck

### Active Projects and Committers

- [`expressjs/response-time`](https:/expressjs/response-time): @carpasse
- [`expressjs/compression`](https:/expressjs/compression): @bjohansebas
Copy link
Member

@blakeembrey blakeembrey Oct 8, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

What's the difference between this and ### Active Projects and Captains? Can we merge them? Ideally there isn't two different project lists and committers, it seems like the captains should be updated instead?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Based on the last discussion (context) comitters and captains are different roles (different access level and responsibilities). Also currently we manage that in different Github teams.

Maybe we can use the same project list and add a sub-list in each project for the captains and comitters. So we duplicate less. But not sure if that solves the thing 🤔

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Got it, I think it makes sense for them to be separate. Should this be a list we commit or can we manage it in GitHub and make the teams public?

If you really want to commit it, maybe move it below the current active project list and make it a sub-title like Active Committers? Having two sections in a long document calls "active projects" is my main confusion, and committing committers or putting them first makes less sense as I assume this document is the one which we expect people to attend to when they need to contact the DRI for a project.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I see more collaborators in the list here that aren't being committed: https:/orgs/expressjs/teams.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants