Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Changed default view engine to pug #236

Open
wants to merge 6 commits into
base: master
Choose a base branch
from
Open

Changed default view engine to pug #236

wants to merge 6 commits into from

Conversation

ghost
Copy link

@ghost ghost commented Aug 17, 2019

npm says that jade package includes some security vulnerabilities which is one of them is critical.
so, I changed the default engine immediately.
I didn't tested the app, since I don't know how to do it.

@ghost
Copy link
Author

ghost commented Aug 17, 2019

Changed default view engine from jade to pug.
Also adjusted tests.

@sam-github
Copy link

I'd like to see this change as well, having security vulns in the default use case isn't something that should be enouraged for express users (or any project).

@replacepreg this needs additional changes:

  1. package.engines.node has to change to > 0.12
  2. package.version has to change to 5.0.0 (because dropping support for a node version is semver-major)
  3. .travis.yml needs 0.10 and 0.12 removed

Maintainers - opinions?

https://www.npmjs.com/package/jade has been thorougly deprecated, its not a good default.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant