Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Need some way to differentiate between success and failure #11

Open
tristanpemble opened this issue Aug 8, 2014 · 0 comments
Open

Need some way to differentiate between success and failure #11

tristanpemble opened this issue Aug 8, 2014 · 0 comments

Comments

@tristanpemble
Copy link

I can't easily integrate this with other async libraries because:

function myFunction(callback) {
    // ...
    reader.on('error', function(err) {
        callback(err);
    }).on('close', function() {
        callback(null, result);
    });
    // ...
}

Will call the callback twice. Right now I have to do:

function myFunction(callback) {
    // ...
    reader.on('error', function(err) {
        this.hasError =  true;
        callback(err);
    }).on('close', function() {
        if (!this.hasError)
           callback(null, result);
    });
    // ...
}

Which works, but can become problematic when passing async callbacks everywhere

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant